Re: [PATCH] lib/find_bit: Add find_prev_*_bit functions.

2020-12-02 Thread Andy Shevchenko
On Wed, Dec 02, 2020 at 09:26:05AM -0800, Yury Norov wrote: > On Wed, Dec 2, 2020 at 3:50 AM Yun Levi wrote: ... > I think this patch has some good catches. We definitely need to implement > find_last_zero_bit(), as it is used by fs/ufs, and their local > implementation is not optimal. Side no

Re: [PATCH] lib/find_bit: Add find_prev_*_bit functions.

2020-12-02 Thread Andy Shevchenko
On Wed, Dec 02, 2020 at 08:50:24PM +0900, Yun Levi wrote: > Thanks for kind advice. But I'm so afraid to have questions below: > > > - it proposes functionality w/o user (dead code) > Actually, I add these series functions to rewrite some of the > resource clean-up routine. > A typical

Re: [PATCH] lib/find_bit: Add find_prev_*_bit functions.

2020-12-02 Thread Yun Levi
Thanks for kind advice. But I'm so afraid to have questions below: > - it proposes functionality w/o user (dead code) Actually, I add these series functions to rewrite some of the resource clean-up routine. A typical case is ethtool_set_per_queue_coalesce 's rollback label. Could t

Re: [PATCH] lib/find_bit: Add find_prev_*_bit functions.

2020-12-02 Thread Rasmus Villemoes
On 02/12/2020 10.47, Andy Shevchenko wrote: > On Wed, Dec 02, 2020 at 10:10:09AM +0900, Yun Levi wrote: >> Inspired find_next_*bit function series, add find_prev_*_bit series. >> I'm not sure whether it'll be used right now But, I add these functions >> for future usage. > > This patch has few iss

Re: [PATCH] lib/find_bit: Add find_prev_*_bit functions.

2020-12-02 Thread Andy Shevchenko
On Wed, Dec 02, 2020 at 10:10:09AM +0900, Yun Levi wrote: > Inspired find_next_*bit function series, add find_prev_*_bit series. > I'm not sure whether it'll be used right now But, I add these functions > for future usage. This patch has few issues: - it has more things than described (should be s

[PATCH] lib/find_bit: Add find_prev_*_bit functions.

2020-12-01 Thread Yun Levi
Inspired find_next_*bit function series, add find_prev_*_bit series. I'm not sure whether it'll be used right now But, I add these functions for future usage. Signed-off-by: Levi Yun --- fs/ufs/util.h | 24 +++--- include/asm-generic/bitops/find.h | 69 inc