Re: [PATCH] leds: bcm6328: Handle default-state of LEDs correctly

2015-10-28 Thread Jacek Anaszewski
Hi Simon, On 10/26/2015 01:36 PM, Simon Arlott wrote: On Mon, October 26, 2015 08:45, Jacek Anaszewski wrote: Hi Simon, Thanks for the patch. There are conflicts when applying it to the LED tree: git://git.kernel.org/pub/scm/linux/kernel/git/j.anaszewski/linux-leds.git Please use it as a cod

Re: [PATCH] leds: bcm6328: Handle default-state of LEDs correctly

2015-10-26 Thread Simon Arlott
On Mon, October 26, 2015 08:45, Jacek Anaszewski wrote: > Hi Simon, > > Thanks for the patch. There are conflicts when applying > it to the LED tree: > > git://git.kernel.org/pub/scm/linux/kernel/git/j.anaszewski/linux-leds.git > > Please use it as a code base for your LED development. This has al

Re: [PATCH] leds: bcm6328: Handle default-state of LEDs correctly

2015-10-26 Thread Jacek Anaszewski
Hi Simon, Thanks for the patch. There are conflicts when applying it to the LED tree: git://git.kernel.org/pub/scm/linux/kernel/git/j.anaszewski/linux-leds.git Please use it as a code base for your LED development. When patching existing drivers, please always copy its author(s). Cc Alvaro an

[PATCH] leds: bcm6328: Handle default-state of LEDs correctly

2015-10-24 Thread Simon Arlott
The default-state handler assumes that the LED is active low and omits use of the shift macro causing "keep" to misdetect the state. Determine the brightness and then use the led set function to apply it. Update the documentation to indicate that this driver works for the BCM63168 (which has many