Re: [PATCH] leds: add led_trigger_rename function

2012-09-15 Thread Fabio Baltieri
Hi Kurt, On Mon, Sep 10, 2012 at 03:55:35PM +0200, Kurt Van Dijck wrote: > > > > This also implies that "name" in "struct led_trigger" is not const > > anymore. > IMHO, this is wrong. This forces all other led_triggers > to put their name in non-const storage. I had a second check on the patch a

Re: [PATCH] leds: add led_trigger_rename function

2012-09-10 Thread Fabio Baltieri
On Mon, Sep 10, 2012 at 03:55:35PM +0200, Kurt Van Dijck wrote: > On Sun, Sep 09, 2012 at 05:27:54PM +0200, Fabio Baltieri wrote: > > Implements a led_trigger_rename() function to rename a trigger with > > proper locking. > This is the way to go. > Maybe add 'default_trigger' tests? In a later phas

Re: [PATCH] leds: add led_trigger_rename function

2012-09-10 Thread Kurt Van Dijck
Hey Fabio, On Sun, Sep 09, 2012 at 05:27:54PM +0200, Fabio Baltieri wrote: > Implements a led_trigger_rename() function to rename a trigger with > proper locking. This is the way to go. Maybe add 'default_trigger' tests? In a later phase? > > This also implies that "name" in "struct led_trigger"

[PATCH] leds: add led_trigger_rename function

2012-09-09 Thread Fabio Baltieri
Implements a led_trigger_rename() function to rename a trigger with proper locking. This also implies that "name" in "struct led_trigger" is not const anymore. Signed-off-by: Fabio Baltieri Cc: Kurt Van Dijck Cc: Bryan Wu --- Hi all, this adds a led_trigger_rename_static() function to change