Re: [PATCH] leds: USB: Add support for MSI GT683R led panels

2014-06-05 Thread Daniele Forsi
2014-06-05 13:06 GMT+02:00: >> + dev_err(&led->usb_dev->dev, "Message to be send to device is >> too long\n"); there's a typo: s/send/sent/ -- Daniele Forsi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.

Re: [PATCH] leds: USB: Add support for MSI GT683R led panels

2014-06-05 Thread Johan Hovold
[ +CC: linux-usb ] On Sat, May 31, 2014 at 06:46:44PM +0300, Janne Kanniainen wrote: > This driver adds support for USB controlled led panels that exist in MSI > GT683R laptop. > > Signed-off-by: Janne Kanniainen > --- > drivers/leds/Kconfig | 6 ++ > drivers/leds/Makefile | 1 +

Re: [PATCH] leds: USB: Add support for MSI GT683R led panels

2014-06-04 Thread Bryan Wu
On Sat, May 31, 2014 at 8:46 AM, Janne Kanniainen wrote: > This driver adds support for USB controlled led panels that exist in MSI > GT683R laptop. > Thanks for this patch, basically it looks good to me. Just some picky improvement as bellow. > Signed-off-by: Janne Kanniainen > --- > drivers

[PATCH] leds: USB: Add support for MSI GT683R led panels

2014-05-31 Thread Janne Kanniainen
This driver adds support for USB controlled led panels that exist in MSI GT683R laptop. Signed-off-by: Janne Kanniainen --- drivers/leds/Kconfig | 6 ++ drivers/leds/Makefile | 1 + drivers/leds/leds-gt683r.c | 241 + 3 files changed, 2