Re: [PATCH] leds/leds-s3c24xx: use devm_gpio_request

2012-07-12 Thread devendra.aaru
On Fri, Jul 13, 2012 at 9:12 AM, Bryan Wu wrote: > On Wed, Jul 11, 2012 at 5:50 PM, Devendra Naga > wrote: >> Bryan, >> >> This patch is not even compile tested, since my machine crashed, and >> didn't have the ARM toolchain, sorry .. >> > > Thanks, I built it successfully. It looks fine

Re: [PATCH] leds/leds-s3c24xx: use devm_gpio_request

2012-07-12 Thread Bryan Wu
On Wed, Jul 11, 2012 at 5:50 PM, Devendra Naga wrote: > why? > because if the led_classdev_register fails we wont do gpio free > because using devm_ functions, there is no need for error paths > > Signed-off-by: Devendra Naga > --- > Bryan, > > This patch is not even compile tested, since

[PATCH] leds/leds-s3c24xx: use devm_gpio_request

2012-07-11 Thread Devendra Naga
why? because if the led_classdev_register fails we wont do gpio free because using devm_ functions, there is no need for error paths Signed-off-by: Devendra Naga --- Bryan, This patch is not even compile tested, since my machine crashed, and didn't have the ARM toolchain, sorry ..