Re: [PATCH] leaking_addresses: add support for 32-bit kernel addresses

2017-12-04 Thread Tobin C. Harding
On Mon, Dec 04, 2017 at 03:50:41PM +0530, kaiwan.billimo...@gmail.com wrote: > On Mon, 2017-12-04 at 19:21 +1100, Tobin C. Harding wrote: > > On Mon, Dec 04, 2017 at 10:51:53AM +0530, Kaiwan N Billimoria wrote: > > > > --- > > > diff --git a/scripts/leaking_addresses.pl b/scripts/leaking_addresses.

Re: [PATCH] leaking_addresses: add support for 32-bit kernel addresses

2017-12-04 Thread Kaiwan N Billimoria
Sure, thanks Alexander.. Tobin, request you to pl make the change while merging, thanks.. Thanks & Regards, Kaiwan. On Mon, Dec 4, 2017 at 6:07 PM, Alexander Kapshuk wrote: > On Mon, Dec 4, 2017 at 12:20 PM, wrote: >> On Mon, 2017-12-04 at 19:21 +1100, Tobin C. Harding wrote: >>> On Mon, Dec

Re: [PATCH] leaking_addresses: add support for 32-bit kernel addresses

2017-12-04 Thread Alexander Kapshuk
On Mon, Dec 4, 2017 at 12:20 PM, wrote: > On Mon, 2017-12-04 at 19:21 +1100, Tobin C. Harding wrote: >> On Mon, Dec 04, 2017 at 10:51:53AM +0530, Kaiwan N Billimoria wrote: >> > > --- >> > diff --git a/scripts/leaking_addresses.pl b/scripts/leaking_addresses.pl >> > index 9906dcf8b807..260b52e456

Re: [PATCH] leaking_addresses: add support for 32-bit kernel addresses

2017-12-04 Thread kaiwan . billimoria
On Mon, 2017-12-04 at 19:21 +1100, Tobin C. Harding wrote: > On Mon, Dec 04, 2017 at 10:51:53AM +0530, Kaiwan N Billimoria wrote: > > > --- > > diff --git a/scripts/leaking_addresses.pl b/scripts/leaking_addresses.pl > > index 9906dcf8b807..260b52e456f1 100755 > > --- a/scripts/leaking_addresses.pl

Re: [PATCH] leaking_addresses: add support for 32-bit kernel addresses

2017-12-04 Thread Tobin C. Harding
On Mon, Dec 04, 2017 at 10:51:53AM +0530, Kaiwan N Billimoria wrote: > > On Mon, Dec 4, 2017 at 10:25 AM, Tobin C. Harding wrote: > >> > >> > With the 'eval', no warning, it's fine. > >> > >> Why not use hex()? > > > >> > > >> > foreach my $config_file (@config_files) { > >> > +

Re: [PATCH] leaking_addresses: add support for 32-bit kernel addresses

2017-12-03 Thread Kaiwan N Billimoria
> On Mon, Dec 4, 2017 at 10:25 AM, Tobin C. Harding wrote: >> >> > With the 'eval', no warning, it's fine. >> >> Why not use hex()? > >> > >> > foreach my $config_file (@config_files) { >> > + $config_file =~ s/\R*//g; >> >> Is there some reason you don't use chomp()? > Wrt

Re: [PATCH] leaking_addresses: add support for 32-bit kernel addresses

2017-12-03 Thread Kaiwan N Billimoria
On Mon, Dec 4, 2017 at 10:25 AM, Tobin C. Harding wrote: > > > With the 'eval', no warning, it's fine. > > Why not use hex()? > > > > foreach my $config_file (@config_files) { > > + $config_file =~ s/\R*//g; > > Is there some reason you don't use chomp()? Tobin, now you can

Re: [PATCH] leaking_addresses: add support for 32-bit kernel addresses

2017-12-03 Thread Tobin C. Harding
On Mon, Dec 04, 2017 at 10:11:21AM +0530, kaiwan.billimo...@gmail.com wrote: > On Mon, 2017-12-04 at 11:11 +1100, Tobin C. Harding wrote: > > On Fri, Dec 01, 2017 at 06:39:07PM +0530, kaiwan.billimo...@gmail.com wrote: > > > > @@ -267,7 +266,7 @@ sub is_false_positive > > > sub is_false_positive_

Re: [PATCH] leaking_addresses: add support for 32-bit kernel addresses

2017-12-03 Thread kaiwan . billimoria
On Mon, 2017-12-04 at 11:11 +1100, Tobin C. Harding wrote: > On Fri, Dec 01, 2017 at 06:39:07PM +0530, kaiwan.billimo...@gmail.com wrote: > > @@ -267,7 +266,7 @@ sub is_false_positive > > sub is_false_positive_ix86_32 > > { > > my ($match) = @_; > > - state $page_offset = get_page_offset()

Re: [PATCH] leaking_addresses: add support for 32-bit kernel addresses

2017-12-03 Thread Tobin C. Harding
On Fri, Dec 01, 2017 at 06:39:07PM +0530, kaiwan.billimo...@gmail.com wrote: > Hi, > > Applies upon the previous one in this thread. > Found and fixed some minor issues with light testing on a 32-bit x86. > (I realize this isn't an ideal description, forgive me!). > > Have also emitted a 'noisy'

Re: [PATCH] leaking_addresses: add support for 32-bit kernel addresses

2017-12-01 Thread kaiwan . billimoria
Hi, Applies upon the previous one in this thread. Found and fixed some minor issues with light testing on a 32-bit x86. (I realize this isn't an ideal description, forgive me!). Have also emitted a 'noisy' warning on PAGE_OFFSET fallback to 0xc. Signed-off-by: Kaiwan N Billimoria --- s

Re: [PATCH] leaking_addresses: add support for 32-bit kernel addresses

2017-12-01 Thread Kaiwan N Billimoria
Hi, Pl see my re inline below.. Will also follow up this mail with a patch with (minor) fixes for the last one Tobin sent, and, hopefully, that should mostly have the whole thing done (for now at least!).. Thanks, Kaiwan. On Thu, Nov 30, 2017 at 2:18 AM, Tobin C. Harding wrote: > On Wed, Nov 29

Re: [PATCH] leaking_addresses: add support for 32-bit kernel addresses

2017-11-29 Thread Tobin C. Harding
On Wed, Nov 29, 2017 at 04:32:54PM +0530, Kaiwan N Billimoria wrote: > Hi, > > On Wed, Nov 29, 2017 at 3:46 PM, Tobin C. Harding wrote: > > On Wed, Nov 29, 2017 at 09:59:59AM +0200, Alexander Kapshuk wrote: > >> On Tue, Nov 28, 2017 at 11:10 PM, Tobin C. Harding wrote: > >> > On Tue, Nov 28, 201

Re: [PATCH] leaking_addresses: add support for 32-bit kernel addresses

2017-11-29 Thread Alexander Kapshuk
On Wed, Nov 29, 2017 at 12:16 PM, Tobin C. Harding wrote: > On Wed, Nov 29, 2017 at 09:59:59AM +0200, Alexander Kapshuk wrote: >> On Tue, Nov 28, 2017 at 11:10 PM, Tobin C. Harding wrote: >> > On Tue, Nov 28, 2017 at 03:16:24PM +0200, Alexander Kapshuk wrote: >> >> On Tue, Nov 28, 2017 at 8:32 AM

Re: [PATCH] leaking_addresses: add support for 32-bit kernel addresses

2017-11-29 Thread Kaiwan N Billimoria
Hi, On Wed, Nov 29, 2017 at 3:46 PM, Tobin C. Harding wrote: > On Wed, Nov 29, 2017 at 09:59:59AM +0200, Alexander Kapshuk wrote: >> On Tue, Nov 28, 2017 at 11:10 PM, Tobin C. Harding wrote: >> > On Tue, Nov 28, 2017 at 03:16:24PM +0200, Alexander Kapshuk wrote: >> >> On Tue, Nov 28, 2017 at 8:3

Re: [PATCH] leaking_addresses: add support for 32-bit kernel addresses

2017-11-29 Thread Tobin C. Harding
On Wed, Nov 29, 2017 at 09:59:59AM +0200, Alexander Kapshuk wrote: > On Tue, Nov 28, 2017 at 11:10 PM, Tobin C. Harding wrote: > > On Tue, Nov 28, 2017 at 03:16:24PM +0200, Alexander Kapshuk wrote: > >> On Tue, Nov 28, 2017 at 8:32 AM, Tobin C. Harding wrote: > >> > Currently, leaking_addresses.p

Re: [PATCH] leaking_addresses: add support for 32-bit kernel addresses

2017-11-29 Thread Alexander Kapshuk
On Tue, Nov 28, 2017 at 11:10 PM, Tobin C. Harding wrote: > On Tue, Nov 28, 2017 at 03:16:24PM +0200, Alexander Kapshuk wrote: >> On Tue, Nov 28, 2017 at 8:32 AM, Tobin C. Harding wrote: >> > Currently, leaking_addresses.pl only supports scanning 64 bit >> > architectures. This is due to how the

Re: [PATCH] leaking_addresses: add support for 32-bit kernel addresses

2017-11-28 Thread Tobin C. Harding
On Tue, Nov 28, 2017 at 03:16:24PM +0200, Alexander Kapshuk wrote: > On Tue, Nov 28, 2017 at 8:32 AM, Tobin C. Harding wrote: > > Currently, leaking_addresses.pl only supports scanning 64 bit > > architectures. This is due to how the regular expressions are formed. We > > can do better than this.

Re: [PATCH] leaking_addresses: add support for 32-bit kernel addresses

2017-11-28 Thread Alexander Kapshuk
On Tue, Nov 28, 2017 at 8:32 AM, Tobin C. Harding wrote: > Currently, leaking_addresses.pl only supports scanning 64 bit > architectures. This is due to how the regular expressions are formed. We > can do better than this. 32 architectures can be supported if we take > into consideration the kerne

[PATCH] leaking_addresses: add support for 32-bit kernel addresses

2017-11-27 Thread Tobin C. Harding
Currently, leaking_addresses.pl only supports scanning 64 bit architectures. This is due to how the regular expressions are formed. We can do better than this. 32 architectures can be supported if we take into consideration the kernel virtual address split. Add support for ix86 32 bit architecture