Re: [PATCH] latencytop: Change Kconfig dependency.

2008-02-01 Thread Heiko Carstens
> > +config HAVE_LATENCYTOP_SUPPORT > > + def_bool y > > + > No. > Please do: > config X86 > + select HAVE_LATENCYTOP_SUPPORT > > Yes - this is a valid use of select. > > See Documentation/kbuild/kconfig-language.txt Ok, I wasn't aware of that. For now I'll leave it as is as Ingo requeste

Re: [PATCH] latencytop: Change Kconfig dependency.

2008-02-01 Thread Sam Ravnborg
On Fri, Feb 01, 2008 at 02:32:28PM +0100, Ingo Molnar wrote: > > * Sam Ravnborg <[EMAIL PROTECTED]> wrote: > > > > config STACKTRACE_SUPPORT > > > def_bool y > > > > > > +config HAVE_LATENCYTOP_SUPPORT > > > + def_bool y > > > + > > No. > > Please do: > > config X86 > > + select HAVE_LATE

Re: [PATCH] latencytop: Change Kconfig dependency.

2008-02-01 Thread Ingo Molnar
* Sam Ravnborg <[EMAIL PROTECTED]> wrote: > > config STACKTRACE_SUPPORT > > def_bool y > > > > +config HAVE_LATENCYTOP_SUPPORT > > + def_bool y > > + > No. > Please do: > config X86 > + select HAVE_LATENCYTOP_SUPPORT > > Yes - this is a valid use of select. i see - and there's lot

Re: [PATCH] latencytop: Change Kconfig dependency.

2008-02-01 Thread Sam Ravnborg
On Fri, Feb 01, 2008 at 02:06:36PM +0100, Heiko Carstens wrote: > From: Heiko Carstens <[EMAIL PROTECTED]> > > Change latencytop Kconfig entry so it doesn't list the archictectures > that support it. Instead introduce HAVE_LATENCY_SUPPORT which any > architecture can set. Should reduce patch confl

Re: [PATCH] latencytop: Change Kconfig dependency.

2008-02-01 Thread Ingo Molnar
* Heiko Carstens <[EMAIL PROTECTED]> wrote: > From: Heiko Carstens <[EMAIL PROTECTED]> > > Change latencytop Kconfig entry so it doesn't list the archictectures > that support it. Instead introduce HAVE_LATENCY_SUPPORT which any > architecture can set. Should reduce patch conflicts. thanks, a

[PATCH] latencytop: Change Kconfig dependency.

2008-02-01 Thread Heiko Carstens
From: Heiko Carstens <[EMAIL PROTECTED]> Change latencytop Kconfig entry so it doesn't list the archictectures that support it. Instead introduce HAVE_LATENCY_SUPPORT which any architecture can set. Should reduce patch conflicts. Cc: Arjan van de Ven <[EMAIL PROTECTED]> Cc: Ingo Molnar <[EMAIL PR