Re: [PATCH] kvm: x86: correct the misleading comment in vmx_handle_external_intr

2016-10-12 Thread Radim Krčmář
2016-10-12 09:15+0800, Longpeng (Mike): > On 2016/10/12 2:23, Radim Krčmář wrote: >> This part is acceptable as it gives a new information code, yet the >> function does not modify flags, which makes it unremarkable. >> And dependencies on the caller would be better described in a header >> (if we

Re: [PATCH] kvm: x86: correct the misleading comment in vmx_handle_external_intr

2016-10-11 Thread Longpeng (Mike)
Hi Radim, On 2016/10/12 2:23, Radim Krčmář wrote: > This part is acceptable as it gives a new information code, yet the > function does not modify flags, which makes it unremarkable. > And dependencies on the caller would be better described in a header > (if we cannot express them well in the co

Re: [PATCH] kvm: x86: correct the misleading comment in vmx_handle_external_intr

2016-10-11 Thread Radim Krčmář
2016-10-10 08:23+0800, Longpeng(Mike): > Since Paolo has removed irq-enable-operation in vmx_handle_external_intr > (KVM: x86: use guest_exit_irqoff), the original comment about the IF bit > in rflags is incorrect now. > > Signed-off-by: Longpeng(Mike) > --- > diff --git a/arch/x86/kvm/vmx.c b/ar

[PATCH] kvm: x86: correct the misleading comment in vmx_handle_external_intr

2016-10-09 Thread Longpeng(Mike)
Since Paolo has removed irq-enable-operation in vmx_handle_external_intr (KVM: x86: use guest_exit_irqoff), the original comment about the IF bit in rflags is incorrect now. Signed-off-by: Longpeng(Mike) --- arch/x86/kvm/vmx.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff