Re: [PATCH] kvm: x86: Use DEFINE_DEBUGFS_ATTRIBUTE for debugfs files

2019-09-18 Thread Greg KH
On Wed, Sep 18, 2019 at 08:19:44AM +0800, wang.y...@zte.com.cn wrote: > Hi Paolo, > > > On 22/07/19 09:33, Yi Wang wrote: > > > We got these coccinelle warning: > > > ./arch/x86/kvm/debugfs.c:23:0-23: WARNING: vcpu_timer_advance_ns_fops > > > should be defined with DEFINE_DEBUGFS_ATTRIBUTE > > > .

Re: [PATCH] kvm: x86: Use DEFINE_DEBUGFS_ATTRIBUTE for debugfs files

2019-09-17 Thread Paolo Bonzini
On 17/09/19 20:12, Greg Kroah-Hartman wrote: > On Tue, Sep 17, 2019 at 07:18:33PM +0200, Paolo Bonzini wrote: >> On 22/07/19 09:33, Yi Wang wrote: >>> We got these coccinelle warning: >>> ./arch/x86/kvm/debugfs.c:23:0-23: WARNING: vcpu_timer_advance_ns_fops >>> should be defined with DEFINE_DEBUGFS

Re: [PATCH] kvm: x86: Use DEFINE_DEBUGFS_ATTRIBUTE for debugfs files

2019-09-17 Thread Greg Kroah-Hartman
On Tue, Sep 17, 2019 at 07:18:33PM +0200, Paolo Bonzini wrote: > On 22/07/19 09:33, Yi Wang wrote: > > We got these coccinelle warning: > > ./arch/x86/kvm/debugfs.c:23:0-23: WARNING: vcpu_timer_advance_ns_fops > > should be defined with DEFINE_DEBUGFS_ATTRIBUTE > > ./arch/x86/kvm/debugfs.c:32:0-23:

Re: [PATCH] kvm: x86: Use DEFINE_DEBUGFS_ATTRIBUTE for debugfs files

2019-09-17 Thread Paolo Bonzini
On 22/07/19 09:33, Yi Wang wrote: > We got these coccinelle warning: > ./arch/x86/kvm/debugfs.c:23:0-23: WARNING: vcpu_timer_advance_ns_fops > should be defined with DEFINE_DEBUGFS_ATTRIBUTE > ./arch/x86/kvm/debugfs.c:32:0-23: WARNING: vcpu_tsc_offset_fops should > be defined with DEFINE_DEBUGFS_AT

[PATCH] kvm: x86: Use DEFINE_DEBUGFS_ATTRIBUTE for debugfs files

2019-07-22 Thread Yi Wang
We got these coccinelle warning: ./arch/x86/kvm/debugfs.c:23:0-23: WARNING: vcpu_timer_advance_ns_fops should be defined with DEFINE_DEBUGFS_ATTRIBUTE ./arch/x86/kvm/debugfs.c:32:0-23: WARNING: vcpu_tsc_offset_fops should be defined with DEFINE_DEBUGFS_ATTRIBUTE ./arch/x86/kvm/debugfs.c:41:0-23: WA