Re: [PATCH] kvm, x86: Properly check whether a pfn is an MMIO or not

2016-09-15 Thread Paolo Bonzini
On 15/09/2016 18:04, Kani, Toshimitsu wrote: > On Thu, 2016-09-15 at 08:22 +0200, Paolo Bonzini wrote: >> >> On 15/09/2016 07:54, Raslan, KarimAllah wrote: >>> >>> On Jun 22, 2016, at 3:41 PM, Paolo Bonzini wrote: On 22/06/2016 04:34, KarimAllah Ahmed wrote: >>

Re: [PATCH] kvm, x86: Properly check whether a pfn is an MMIO or not

2016-09-15 Thread Kani, Toshimitsu
On Thu, 2016-09-15 at 08:22 +0200, Paolo Bonzini wrote: > > On 15/09/2016 07:54, Raslan, KarimAllah wrote: > > > > > > > > > > On Jun 22, 2016, at 3:41 PM, Paolo Bonzini > > > wrote: > > > > > > > > > > > > On 22/06/2016 04:34, KarimAllah Ahmed wrote: > > > > > > > > pfn_valid check is not

Re: [PATCH] kvm, x86: Properly check whether a pfn is an MMIO or not

2016-09-14 Thread Paolo Bonzini
On 15/09/2016 07:54, Raslan, KarimAllah wrote: > >> On Jun 22, 2016, at 3:41 PM, Paolo Bonzini wrote: >> >> >> >> On 22/06/2016 04:34, KarimAllah Ahmed wrote: >>> pfn_valid check is not sufficient because it only checks if a page has a >>> struct >>> page or not, if for example "mem=" was pass

Re: [PATCH] kvm, x86: Properly check whether a pfn is an MMIO or not

2016-09-14 Thread Raslan, KarimAllah
> On Jun 22, 2016, at 3:41 PM, Paolo Bonzini wrote: > > > > On 22/06/2016 04:34, KarimAllah Ahmed wrote: >> pfn_valid check is not sufficient because it only checks if a page has a >> struct >> page or not, if for example "mem=" was passed to the kernel some valid pages >> won't have a struct

Re: [PATCH] kvm, x86: Properly check whether a pfn is an MMIO or not

2016-06-22 Thread Raslan, KarimAllah
On 6/22/16, 3:41 PM, "Paolo Bonzini" wrote: > > >On 22/06/2016 04:34, KarimAllah Ahmed wrote: >> pfn_valid check is not sufficient because it only checks if a page has a >> struct >> page or not, if for example "mem=" was passed to the kernel some valid pages >> won't have a struct page. This

Re: [PATCH] kvm, x86: Properly check whether a pfn is an MMIO or not

2016-06-22 Thread Paolo Bonzini
On 22/06/2016 04:34, KarimAllah Ahmed wrote: > pfn_valid check is not sufficient because it only checks if a page has a > struct > page or not, if for example "mem=" was passed to the kernel some valid pages > won't have a struct page. This means that if guests were assigned valid memory > that

[PATCH] kvm, x86: Properly check whether a pfn is an MMIO or not

2016-06-21 Thread KarimAllah Ahmed
pfn_valid check is not sufficient because it only checks if a page has a struct page or not, if for example "mem=" was passed to the kernel some valid pages won't have a struct page. This means that if guests were assigned valid memory that lies after the mem= boundary it will be passed uncached to