Re: [PATCH] kthread: Make kthread_create() killable.

2013-09-15 Thread Oleg Nesterov
Hi Tetsuo, please do not start the off-list discussions ;) On 09/15, Tetsuo Handa wrote: > > I examined do_coredump() case and found similar result. ... > Do we want to change from call_usermodehelper_exec(UMH_WAIT_EXEC) to > call_usermodehelper_exec(UMH_WAIT_EXEC | UMH_WAIT_KILLABLE) To me, t

Re: [PATCH] kthread: Make kthread_create() killable.

2013-09-15 Thread Oleg Nesterov
On 09/15, Tetsuo Handa wrote: > > Oleg Nesterov wrote: > > I am wondering if this can be simplified... > > > > At least you can move create->done from kthread_create_info to the > > stack, and turn create->owner into the pointer to that completion. > > Use of DECLARE_COMPLETION_ONSTACK() looks harm

Re: [PATCH] kthread: Make kthread_create() killable.

2013-09-14 Thread Tetsuo Handa
Oleg Nesterov wrote: > I am wondering if this can be simplified... > > At least you can move create->done from kthread_create_info to the > stack, and turn create->owner into the pointer to that completion. Use of DECLARE_COMPLETION_ONSTACK() looks harmful to me because current thread needs to be

Re: [PATCH] kthread: Make kthread_create() killable.

2013-09-14 Thread Oleg Nesterov
Add lkml. On 09/13, Tetsuo Handa wrote: > > This patch makes kthread_create() killable, Probably makes sense... > @@ -255,36 +266,59 @@ struct task_struct *kthread_create_on_node(int > (*threadfn)(void *data), > const char namefmt[], >