[PATCH] kref: minor cleanup

2013-05-07 Thread Anatol Pomozov
* make warning smp-safe * result of atomic _unless_zero functions should be checked by caller to avoid use-after-free error * minor stylistic fixes Link: https://lkml.org/lkml/2013/4/12/391 Tested: compile x86, boot machine and run xfstests Signed-off-by: Anatol Pomozov --- include/linux/kr

Re: [PATCH] kref: minor cleanup

2013-04-24 Thread Anatol Pomozov
Hi On Sat, Apr 20, 2013 at 3:34 PM, Greg KH wrote: > On Sat, Apr 20, 2013 at 09:15:10AM -0700, Anatol Pomozov wrote: >> Follow-up for https://lkml.org/lkml/2013/4/12/391 > > That's not needed in a changelog comment. > >> * make warning smp-safe >> * result of atomic _unless_zero functions should

Re: [PATCH] kref: minor cleanup

2013-04-20 Thread Greg KH
On Sat, Apr 20, 2013 at 09:15:10AM -0700, Anatol Pomozov wrote: > Follow-up for https://lkml.org/lkml/2013/4/12/391 That's not needed in a changelog comment. > * make warning smp-safe > * result of atomic _unless_zero functions should be checked by caller > to avoid use-after-free error You

Re: [PATCH] kref: minor cleanup

2013-04-20 Thread Greg KH
On Fri, Apr 19, 2013 at 09:27:20PM -0700, Anatol Pomozov wrote: > >> -static struct kobject *kobject_get_unless_zero(struct kobject *kobj) > >> +static struct kobject *__must_check kobject_get_unless_zero( > >> + struct kobject *kobj) > > > > __must_check needs to be in the .h file, not

[PATCH] kref: minor cleanup

2013-04-20 Thread Anatol Pomozov
Follow-up for https://lkml.org/lkml/2013/4/12/391 * make warning smp-safe * result of atomic _unless_zero functions should be checked by caller to avoid use-after-free error Signed-off-by: Anatol Pomozov --- include/linux/kobject.h | 1 + include/linux/kref.h| 9 ++--- lib/kobject.c

Re: [PATCH] kref: minor cleanup

2013-04-19 Thread Anatol Pomozov
Hi On Fri, Apr 19, 2013 at 7:24 PM, Greg KH wrote: > On Fri, Apr 19, 2013 at 06:33:54PM -0700, Anatol Pomozov wrote: >> Follow-up for https://lkml.org/lkml/2013/4/12/391 >> >> * make warning smp-safe >> * result of atomic _unless_zero functions should be checked by caller >> to avoid use-afte

Re: [PATCH] kref: minor cleanup

2013-04-19 Thread Greg KH
On Fri, Apr 19, 2013 at 06:33:54PM -0700, Anatol Pomozov wrote: > Follow-up for https://lkml.org/lkml/2013/4/12/391 > > * make warning smp-safe > * result of atomic _unless_zero functions should be checked by caller > to avoid use-after-free error > > Signed-off-by: Anatol Pomozov > --- > i

[PATCH] kref: minor cleanup

2013-04-19 Thread Anatol Pomozov
Follow-up for https://lkml.org/lkml/2013/4/12/391 * make warning smp-safe * result of atomic _unless_zero functions should be checked by caller to avoid use-after-free error Signed-off-by: Anatol Pomozov --- include/linux/kref.h | 9 ++--- lib/kobject.c| 3 ++- 2 files changed,