RE: [PATCH] kprobes: fix compiler warning for !CONFIG_KPROBES_ON_FTRACE

2020-08-05 Thread John Fastabend
Muchun Song wrote: > Fix compiler warning(as show below) for !CONFIG_KPROBES_ON_FTRACE. > > kernel/kprobes.c: In function 'kill_kprobe': > kernel/kprobes.c:1116:33: warning: statement with no effect > [-Wunused-value] > 1116 | #define disarm_kprobe_ftrace(p) (-ENODEV) > |

Re: [PATCH] kprobes: fix compiler warning for !CONFIG_KPROBES_ON_FTRACE

2020-08-05 Thread Masami Hiramatsu
On Thu, 6 Aug 2020 01:20:46 +0800 Muchun Song wrote: > Fix compiler warning(as show below) for !CONFIG_KPROBES_ON_FTRACE. > > kernel/kprobes.c: In function 'kill_kprobe': > kernel/kprobes.c:1116:33: warning: statement with no effect > [-Wunused-value] > 1116 | #define disarm_kprobe_ftrace(p) (

[PATCH] kprobes: fix compiler warning for !CONFIG_KPROBES_ON_FTRACE

2020-08-05 Thread Muchun Song
Fix compiler warning(as show below) for !CONFIG_KPROBES_ON_FTRACE. kernel/kprobes.c: In function 'kill_kprobe': kernel/kprobes.c:1116:33: warning: statement with no effect [-Wunused-value] 1116 | #define disarm_kprobe_ftrace(p) (-ENODEV) | ^ kernel/kprobes.c:

Re: [PATCH] kprobes: fix compiler warning

2013-07-01 Thread Dong Fang
On 07/01/2013 10:33 AM, Dong Fang wrote: Fix the following compiler warning of uninitialized variable kernel/kprobes.c: In function ‘register_kprobe’: kernel/kprobes.c:1493: warning: ‘probed_mod’ may be used uninitialized in this function Signed-off-by: Dong Fang --- kernel/kprobes.

[PATCH] kprobes: fix compiler warning

2013-07-01 Thread Dong Fang
Fix the following compiler warning of uninitialized variable kernel/kprobes.c: In function ‘register_kprobe’: kernel/kprobes.c:1493: warning: ‘probed_mod’ may be used uninitialized in this function Signed-off-by: Dong Fang --- kernel/kprobes.c |2 +- 1 files changed, 1 insertions(+

Re: [PATCH] kprobes: Fix compiler warning

2007-01-30 Thread Kumar Gala
On Jan 30, 2007, at 1:41 AM, Andrew Morton wrote: On Tue, 30 Jan 2007 01:12:17 -0600 Kumar Gala <[EMAIL PROTECTED]> wrote: What are your thoughts on forward Masami patch to Linus for 2.6.20 since it fixes a real bug on PPC? I bumped it up into the for-2.6.20 slot. thanks. - k - To unsub

Re: [PATCH] kprobes: Fix compiler warning

2007-01-29 Thread Andrew Morton
On Tue, 30 Jan 2007 01:12:17 -0600 Kumar Gala <[EMAIL PROTECTED]> wrote: > What are your thoughts on forward Masami patch to Linus for 2.6.20 > since it fixes a real bug on PPC? I bumped it up into the for-2.6.20 slot. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

Re: [PATCH] kprobes: Fix compiler warning

2007-01-29 Thread Kumar Gala
On Jan 30, 2007, at 1:05 AM, Kumar Gala wrote: On Jan 29, 2007, at 11:55 PM, Ananth N Mavinakayanahalli wrote: On Mon, Jan 29, 2007 at 11:43:33PM -0600, Kumar Gala wrote: On ppc the compiler gripes about: kernel/kprobes.c: In function 'collect_garbage_slots': kernel/kprobes.c:215: warning:

Re: [PATCH] kprobes: Fix compiler warning

2007-01-29 Thread Kumar Gala
On Jan 29, 2007, at 11:55 PM, Ananth N Mavinakayanahalli wrote: On Mon, Jan 29, 2007 at 11:43:33PM -0600, Kumar Gala wrote: On ppc the compiler gripes about: kernel/kprobes.c: In function 'collect_garbage_slots': kernel/kprobes.c:215: warning: comparison is always false due to limited rang

Re: [PATCH] kprobes: Fix compiler warning

2007-01-29 Thread Ananth N Mavinakayanahalli
On Mon, Jan 29, 2007 at 11:43:33PM -0600, Kumar Gala wrote: > On ppc the compiler gripes about: > > kernel/kprobes.c: In function 'collect_garbage_slots': > kernel/kprobes.c:215: warning: comparison is always false due to limited > range of data type > > The compiler ends up optimizing away the

[PATCH] kprobes: Fix compiler warning

2007-01-29 Thread Kumar Gala
On ppc the compiler gripes about: kernel/kprobes.c: In function 'collect_garbage_slots': kernel/kprobes.c:215: warning: comparison is always false due to limited range of data type The compiler ends up optimizing away the test since char's are unsigned on ppc. Signed-off-by: Kumar Gala <[EMAIL