Re: [PATCH] kprobes: Introduce is_kprobe_fault()

2008-01-03 Thread Harvey Harrison
On Thu, 2008-01-03 at 12:35 +0530, Ananth N Mavinakayanahalli wrote: > On Wed, Jan 02, 2008 at 08:05:14PM -0800, Harvey Harrison wrote: > > Thanks for the cleanup... > > ... > > > diff --git a/arch/x86/mm/fault_32.c b/arch/x86/mm/fault_32.c > > index a2273d4..f2e909b 100644 > > --- a/arch/x86/mm

Re: [PATCH] kprobes: Introduce is_kprobe_fault()

2008-01-02 Thread Ananth N Mavinakayanahalli
On Wed, Jan 02, 2008 at 08:05:14PM -0800, Harvey Harrison wrote: Thanks for the cleanup... ... > diff --git a/arch/x86/mm/fault_32.c b/arch/x86/mm/fault_32.c > index a2273d4..f2e909b 100644 > --- a/arch/x86/mm/fault_32.c > +++ b/arch/x86/mm/fault_32.c > @@ -33,28 +33,6 @@ > > extern void die(c

Re: [PATCH] kprobes: Introduce is_kprobe_fault()

2008-01-02 Thread Masami Hiramatsu
Hi Harvey, Thank you for greate work! This seems including all of what I've expected. I'll try to test. Please send this to all of kprobe maintainers, Because this involves all of the architectures which kprobes supports. Maintainers; could you help reviewing this? Thank you, Best Regards, Ha

[PATCH] kprobes: Introduce is_kprobe_fault()

2008-01-02 Thread Harvey Harrison
Use a central is_kprobe_fault() inline in kprobes.h to remove all of the arch-dependant, practically identical implementations in avr32, ia64, powerpc, s390, sparc64, and x86. avr32 was the only arch without the preempt_disable/enable pair in its notify_page_fault implementation. This should be c