Re: [PATCH] keys: remove trailing semicolon in macro definition

2020-12-02 Thread Jarkko Sakkinen
On Sat, Nov 28, 2020 at 09:30:44PM -0800, Joe Perches wrote: > On Sun, 2020-11-29 at 06:45 +0200, Jarkko Sakkinen wrote: > > On Fri, Nov 27, 2020 at 11:15:43AM -0800, t...@redhat.com wrote: > > > From: Tom Rix > > > > > > The macro use will already have a semicolon. > > > > > > Signed-off-by: To

Re: [PATCH] keys: remove trailing semicolon in macro definition

2020-11-30 Thread David Howells
Jarkko Sakkinen wrote: > I'm in-between whether this is worth of merging. The commit message > does not help with that decision too much. It is worth merging. It might cause problems for someone using it in the body of an if-statement, say, if they don't put braces in, but do put a semicolon on

Re: [PATCH] keys: remove trailing semicolon in macro definition

2020-11-28 Thread Joe Perches
On Sun, 2020-11-29 at 06:45 +0200, Jarkko Sakkinen wrote: > On Fri, Nov 27, 2020 at 11:15:43AM -0800, t...@redhat.com wrote: > > From: Tom Rix > > > > The macro use will already have a semicolon. > > > > Signed-off-by: Tom Rix > > I'm in-between whether this is worth of merging. The commit mes

Re: [PATCH] keys: remove trailing semicolon in macro definition

2020-11-28 Thread Jarkko Sakkinen
On Fri, Nov 27, 2020 at 11:15:43AM -0800, t...@redhat.com wrote: > From: Tom Rix > > The macro use will already have a semicolon. > > Signed-off-by: Tom Rix I'm in-between whether this is worth of merging. The commit message does not help with that decision too much. /Jarkko

[PATCH] keys: remove trailing semicolon in macro definition

2020-11-28 Thread trix
From: Tom Rix The macro use will already have a semicolon. Signed-off-by: Tom Rix --- include/linux/key.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/linux/key.h b/include/linux/key.h index 0f2e24f13c2b..1b0837c975b9 100644 --- a/include/linux/key.h +++ b/in