Re: [PATCH] kexec: fix out of the ELF headers buffer issue in syscall kexec_file_load()

2015-09-29 Thread joeyli
Hi Minfei, On Tue, Sep 29, 2015 at 11:50:44AM +0800, Minfei Huang wrote: > On 09/28/15 at 02:41pm, Lee, Chun-Yi wrote: > > On big machines have CPU number that's very nearly to consume whole ELF > > headers buffer that's page aligned, 4096, 8192... Then the page fault error > > randomly happened.

Re: [PATCH] kexec: fix out of the ELF headers buffer issue in syscall kexec_file_load()

2015-09-28 Thread Minfei Huang
On 09/28/15 at 02:41pm, Lee, Chun-Yi wrote: > On big machines have CPU number that's very nearly to consume whole ELF > headers buffer that's page aligned, 4096, 8192... Then the page fault error > randomly happened. > > This patch modified the code in fill_up_crash_elf_data() by using > walk_syst

Re: [PATCH] kexec: fix out of the ELF headers buffer issue in syscall kexec_file_load()

2015-09-28 Thread Baoquan He
On 09/28/15 at 05:39pm, joeyli wrote: > On Mon, Sep 28, 2015 at 04:07:57PM +0800, Baoquan He wrote: > > On 09/28/15 at 02:41pm, Lee, Chun-Yi wrote: > > > This issue was hided on small machine that doesn't have too many CPU > > > because > > > the free space of ELF headers buffer can cover the numb

Re: [PATCH] kexec: fix out of the ELF headers buffer issue in syscall kexec_file_load()

2015-09-28 Thread joeyli
On Mon, Sep 28, 2015 at 04:07:57PM +0800, Baoquan He wrote: > On 09/28/15 at 02:41pm, Lee, Chun-Yi wrote: > > On big machines have CPU number that's very nearly to consume whole ELF > > headers buffer that's page aligned, 4096, 8192... Then the page fault error > > randomly happened. > > > > This

Re: [PATCH] kexec: fix out of the ELF headers buffer issue in syscall kexec_file_load()

2015-09-28 Thread joeyli
Hi, On Mon, Sep 28, 2015 at 03:16:41PM +0800, Baoquan He wrote: > Hi Chun-Yi, > > On 09/28/15 at 02:41pm, Lee, Chun-Yi wrote: > > On big machines have CPU number that's very nearly to consume whole ELF > > headers buffer that's page aligned, 4096, 8192... Then the page fault error > > randomly ha

Re: [PATCH] kexec: fix out of the ELF headers buffer issue in syscall kexec_file_load()

2015-09-28 Thread Baoquan He
On 09/28/15 at 02:41pm, Lee, Chun-Yi wrote: > On big machines have CPU number that's very nearly to consume whole ELF > headers buffer that's page aligned, 4096, 8192... Then the page fault error > randomly happened. > > This patch modified the code in fill_up_crash_elf_data() by using > walk_syst

Re: [PATCH] kexec: fix out of the ELF headers buffer issue in syscall kexec_file_load()

2015-09-28 Thread Baoquan He
Hi Chun-Yi, On 09/28/15 at 02:41pm, Lee, Chun-Yi wrote: > On big machines have CPU number that's very nearly to consume whole ELF > headers buffer that's page aligned, 4096, 8192... Then the page fault error > randomly happened. > > This patch modified the code in fill_up_crash_elf_data() by usin

[PATCH] kexec: fix out of the ELF headers buffer issue in syscall kexec_file_load()

2015-09-27 Thread Lee, Chun-Yi
On big machines have CPU number that's very nearly to consume whole ELF headers buffer that's page aligned, 4096, 8192... Then the page fault error randomly happened. This patch modified the code in fill_up_crash_elf_data() by using walk_system_ram_res() instead of walk_system_ram_range() to count