Re: [PATCH] kernfs: remove outdated and confusing comment

2015-04-23 Thread Tejun Heo
On Thu, Apr 23, 2015 at 02:51:26PM +0200, Wolfram Sang wrote: > On Wed, Mar 11, 2015 at 07:45:31AM -0400, Tejun Heo wrote: > > On Wed, Mar 11, 2015 at 11:26:02AM +0100, Wolfram Sang wrote: > > > From: Wolfram Sang > > > > > > Grabbing the parent is not happening anymore since 2010 (e72ceb8ccac5f7

Re: [PATCH] kernfs: remove outdated and confusing comment

2015-04-23 Thread Wolfram Sang
On Wed, Mar 11, 2015 at 07:45:31AM -0400, Tejun Heo wrote: > On Wed, Mar 11, 2015 at 11:26:02AM +0100, Wolfram Sang wrote: > > From: Wolfram Sang > > > > Grabbing the parent is not happening anymore since 2010 (e72ceb8ccac5f7 > > "sysfs: Remove sysfs_get/put_active_two"). Remove this confusing >

Re: [PATCH] kernfs: remove outdated and confusing comment

2015-03-11 Thread Wolfram Sang
> Hmm... poll isn't hooked up for bin files and the behavior isn't well Ah, thanks! I assumed something like that but could not find the relevant code. > defined either. The open file's event counter is never synchronized > to the backing node's. Before the first kernfs_notify(), it won't > tr

Re: [PATCH] kernfs: remove outdated and confusing comment

2015-03-11 Thread Tejun Heo
On Wed, Mar 11, 2015 at 11:26:02AM +0100, Wolfram Sang wrote: > From: Wolfram Sang > > Grabbing the parent is not happening anymore since 2010 (e72ceb8ccac5f7 > "sysfs: Remove sysfs_get/put_active_two"). Remove this confusing > comment. > > Signed-off-by: Wolfram Sang Acked-by: Tejun Heo > F

[PATCH] kernfs: remove outdated and confusing comment

2015-03-11 Thread Wolfram Sang
From: Wolfram Sang Grabbing the parent is not happening anymore since 2010 (e72ceb8ccac5f7 "sysfs: Remove sysfs_get/put_active_two"). Remove this confusing comment. Signed-off-by: Wolfram Sang --- Found while trying to find out why my sysfs-bin file always returns POLLPRI after opening, readin