Re: [PATCH] kernfs: Check KERNFS_HAS_RELEASE before calling kernfs_release_file()

2017-03-16 Thread Greg Kroah-Hartman
On Thu, Mar 16, 2017 at 05:14:30PM -0400, Tejun Heo wrote: > Hello, Greg. > > On Tue, Mar 14, 2017 at 11:08:29AM +0800, Greg Kroah-Hartman wrote: > > Tejun, want to take this through your tree, or at the least, give me an > > ack for this? > > Just acked. I think going through your tree is bette

Re: [PATCH] kernfs: Check KERNFS_HAS_RELEASE before calling kernfs_release_file()

2017-03-16 Thread Tejun Heo
Hello, Greg. On Tue, Mar 14, 2017 at 11:08:29AM +0800, Greg Kroah-Hartman wrote: > Tejun, want to take this through your tree, or at the least, give me an > ack for this? Just acked. I think going through your tree is better for this one. Thanks! -- tejun

Re: [PATCH] kernfs: Check KERNFS_HAS_RELEASE before calling kernfs_release_file()

2017-03-16 Thread Tejun Heo
On Tue, Mar 14, 2017 at 08:17:00AM +0530, Vaibhav Jain wrote: > Recently started seeing a kernel oops when a module tries removing a > memory mapped sysfs bin_attribute. On closer investigation the root > cause seems to be kernfs_release_file() trying to call > kernfs_op.release() callback that's N

Re: [PATCH] kernfs: Check KERNFS_HAS_RELEASE before calling kernfs_release_file()

2017-03-13 Thread Greg Kroah-Hartman
On Tue, Mar 14, 2017 at 08:17:00AM +0530, Vaibhav Jain wrote: > Recently started seeing a kernel oops when a module tries removing a > memory mapped sysfs bin_attribute. On closer investigation the root > cause seems to be kernfs_release_file() trying to call > kernfs_op.release() callback that's N

[PATCH] kernfs: Check KERNFS_HAS_RELEASE before calling kernfs_release_file()

2017-03-13 Thread Vaibhav Jain
Recently started seeing a kernel oops when a module tries removing a memory mapped sysfs bin_attribute. On closer investigation the root cause seems to be kernfs_release_file() trying to call kernfs_op.release() callback that's NULL for such sysfs bin_attributes. The oops occurs when kernfs_release