Re: [PATCH] kernel: module: strncpy issue, using strlcpy instead of strncpy

2013-04-09 Thread Chen Gang
On 2013年04月09日 17:36, Chen Gang wrote: > On 2013年04月09日 09:52, Chen Gang wrote: > > it looks like a bug. for me, I prefer to give length check for it. > > but I am sorry, now, I can not be sure whether it is really a bug. >>> It really is. We don't export any symbols > 128 cha

Re: [PATCH] kernel: module: strncpy issue, using strlcpy instead of strncpy

2013-04-09 Thread Chen Gang
On 2013年04月09日 17:36, Chen Gang wrote: > diff --git a/scripts/kallsyms.c b/scripts/kallsyms.c > index 487ac6f..9ec6d1f 100644 > --- a/scripts/kallsyms.c > +++ b/scripts/kallsyms.c > @@ -145,13 +145,15 @@ static int read_symbol(FILE *in, struct sym_entry *s) > /* include the type field in the

Re: [PATCH] kernel: module: strncpy issue, using strlcpy instead of strncpy

2013-04-09 Thread Chen Gang
On 2013年04月09日 09:52, Chen Gang wrote: it looks like a bug. for me, I prefer to give length check for it. but I am sorry, now, I can not be sure whether it is really a bug. >> It really is. We don't export any symbols > 128 characters, but if we >> did then kallsyms_expand

Re: [PATCH] kernel: module: strncpy issue, using strlcpy instead of strncpy

2013-04-08 Thread Chen Gang
On 2013年04月08日 21:45, Rusty Russell wrote: >> > >> > and for this patch, is it suitable to send patch v2 ? > Yes, that's fine. > thanks, I will send patch v2 (the subject need delete "strncpy issue") >>> >> However, kallsyms_lookup also calls kallsyms_expand_symbol, which >>> >> doesn't stop

Re: [PATCH] kernel: module: strncpy issue, using strlcpy instead of strncpy

2013-04-08 Thread Rusty Russell
Chen Gang writes: > On 2013年04月08日 13:30, Rusty Russell wrote: >> Chen Gang writes: >>> > ownername and namebuf are all NUL terminated string. >>> > >>> > need always let them ended by '\0'. >>> > >>> > Signed-off-by: Chen Gang >>> > --- >>> > kernel/module.c |4 ++-- >>> > 1 files chan

Re: [PATCH] kernel: module: strncpy issue, using strlcpy instead of strncpy

2013-04-08 Thread Chen Gang
On 2013年04月08日 13:30, Rusty Russell wrote: > Chen Gang writes: >> > ownername and namebuf are all NUL terminated string. >> > >> > need always let them ended by '\0'. >> > >> > Signed-off-by: Chen Gang >> > --- >> > kernel/module.c |4 ++-- >> > 1 files changed, 2 insertions(+), 2 deleti

Re: [PATCH] kernel: module: strncpy issue, using strlcpy instead of strncpy

2013-04-07 Thread Rusty Russell
Chen Gang writes: > ownername and namebuf are all NUL terminated string. > > need always let them ended by '\0'. > > Signed-off-by: Chen Gang > --- > kernel/module.c |4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/kernel/module.c b/kernel/module.c > index 3c2

Re: [PATCH] kernel: module: strncpy issue, using strlcpy instead of strncpy

2013-04-07 Thread Chen Gang
On 2013年04月08日 10:48, Chen Gang wrote: > On 2013年04月07日 22:28, Geert Uytterhoeven wrote: >> On Sun, Apr 7, 2013 at 1:38 PM, Chen Gang wrote: ownername and namebuf are all NUL terminated string. need always let them ended by '\0'. Signed-off-by: Chen Gang ---

Re: [PATCH] kernel: module: strncpy issue, using strlcpy instead of strncpy

2013-04-07 Thread Chen Gang
On 2013年04月07日 22:28, Geert Uytterhoeven wrote: > On Sun, Apr 7, 2013 at 1:38 PM, Chen Gang wrote: >> > ownername and namebuf are all NUL terminated string. >> > >> > need always let them ended by '\0'. >> > >> > Signed-off-by: Chen Gang >> > --- >> > kernel/module.c |4 ++-- >> > 1 file

Re: [PATCH] kernel: module: strncpy issue, using strlcpy instead of strncpy

2013-04-07 Thread Geert Uytterhoeven
On Sun, Apr 7, 2013 at 1:38 PM, Chen Gang wrote: > ownername and namebuf are all NUL terminated string. > > need always let them ended by '\0'. > > Signed-off-by: Chen Gang > --- > kernel/module.c |4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/kernel/module.

[PATCH] kernel: module: strncpy issue, using strlcpy instead of strncpy

2013-04-07 Thread Chen Gang
ownername and namebuf are all NUL terminated string. need always let them ended by '\0'. Signed-off-by: Chen Gang --- kernel/module.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/module.c b/kernel/module.c index 3c2c72d..597efd8 100644 --- a/kernel/mod