Re: [PATCH] kernel: events: use offset_in_page macro

2020-06-30 Thread Peter Zijlstra
On Tue, Jun 30, 2020 at 07:42:58AM +, Chen Ni wrote: > Use offset_in_page macro instead of (addr & ~PAGE_MASK). Shees, so now we're replacing a trivial expression with something that's actually longer to type? How does that make sense? > - memcpy(dst, kaddr + (vaddr & ~PAGE_MASK), len);

[PATCH] kernel: events: use offset_in_page macro

2020-06-30 Thread Chen Ni
From: Xu Wang Use offset_in_page macro instead of (addr & ~PAGE_MASK). Signed-off-by: Xu Wang --- kernel/events/uprobes.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/kernel/events/uprobes.c b/kernel/events/uprobes.c index bb0862873dba..44d175d81ed6 100644 --- a/ke

[PATCH] kernel: events: use offset_in_page macro

2020-05-12 Thread Xu Wang
Use offset_in_page macro instead of (addr & ~PAGE_MASK). Signed-off-by: Xu Wang --- kernel/events/uprobes.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/kernel/events/uprobes.c b/kernel/events/uprobes.c index ece7e13..1552ef1 100644 --- a/kernel/events/uprobes.c +++