Re: [PATCH] kernel/sysctl: Resolve missing-field-initializers warnings

2014-10-21 Thread Rustad, Mark D
On Oct 21, 2014, at 12:07 PM, Andrew Morton wrote: > On Sat, 18 Oct 2014 17:39:10 -0700 ebied...@xmission.com (Eric W. Biederman) > wrote: > >> Jeff Kirsher writes: >> >>> From: Mark Rustad >>> >>> Resolve missing-field-initializers warnings in W=2 builds by >>> using designated initializat

Re: [PATCH] kernel/sysctl: Resolve missing-field-initializers warnings

2014-10-21 Thread Andrew Morton
On Sat, 18 Oct 2014 17:39:10 -0700 ebied...@xmission.com (Eric W. Biederman) wrote: > Jeff Kirsher writes: > > > From: Mark Rustad > > > > Resolve missing-field-initializers warnings in W=2 builds by > > using designated initialization. > > ick. No. > > That gcc warning makes no sense. In

Re: [PATCH] kernel/sysctl: Resolve missing-field-initializers warnings

2014-10-18 Thread Eric W. Biederman
Jeff Kirsher writes: > From: Mark Rustad > > Resolve missing-field-initializers warnings in W=2 builds by > using designated initialization. ick. No. That gcc warning makes no sense. In this case heeding it makes the code significantly uglier and significantly more confusing. Eric > Signe

[PATCH] kernel/sysctl: Resolve missing-field-initializers warnings

2014-10-14 Thread Jeff Kirsher
From: Mark Rustad Resolve missing-field-initializers warnings in W=2 builds by using designated initialization. Signed-off-by: Mark Rustad Signed-off-by: Jeff Kirsher --- kernel/sysctl.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/kernel/sysctl.c b/kerne