Re: [PATCH] kernel/resource: Invalid memory access in __release_resource

2015-04-21 Thread Thierry Reding
On Mon, Apr 20, 2015 at 10:49:28PM +0200, Ricardo Ribalda Delgado wrote: > Hello > > On Mon, Apr 20, 2015 at 10:36 PM, Bjorn Helgaas wrote: > > >> > From reading drivers/base/platform.c, it looks like the intent is > >> > that platform device users would use these interfaces: > >> > >> I can tak

Re: [PATCH] kernel/resource: Invalid memory access in __release_resource

2015-04-20 Thread Ricardo Ribalda Delgado
Hello On Mon, Apr 20, 2015 at 10:36 PM, Bjorn Helgaas wrote: >> > From reading drivers/base/platform.c, it looks like the intent is >> > that platform device users would use these interfaces: >> >> I can take a look to modify OF to use insert_resource(), but I still >> think that no matter what,

Re: [PATCH] kernel/resource: Invalid memory access in __release_resource

2015-04-20 Thread Bjorn Helgaas
On Mon, Apr 20, 2015 at 10:24:25PM +0200, Ricardo Ribalda Delgado wrote: > Hi Bjorn! > > Thanks for your promtly response. > > On Mon, Apr 20, 2015 at 9:28 PM, Bjorn Helgaas wrote: > > [+cc Grant (author of ac80a51e2ce5)] > > > > Hi Ricardo, > > > > On Mon, Apr 20, 2015 at 06:22:52PM +0200, Rica

Re: [PATCH] kernel/resource: Invalid memory access in __release_resource

2015-04-20 Thread Ricardo Ribalda Delgado
Hi Bjorn! Thanks for your promtly response. On Mon, Apr 20, 2015 at 9:28 PM, Bjorn Helgaas wrote: > [+cc Grant (author of ac80a51e2ce5)] > > Hi Ricardo, > > On Mon, Apr 20, 2015 at 06:22:52PM +0200, Ricardo Ribalda Delgado wrote: >> >> If of_platform_depopulate is called later, resource->parent

Re: [PATCH] kernel/resource: Invalid memory access in __release_resource

2015-04-20 Thread Bjorn Helgaas
[+cc Grant (author of ac80a51e2ce5)] Hi Ricardo, On Mon, Apr 20, 2015 at 06:22:52PM +0200, Ricardo Ribalda Delgado wrote: > When a resource is initialized via of_platform_populate. > resource->parent is initialized to NULL via kzalloc. > (of_platform_populate->of_device_alloc->of_address_to_resou

[PATCH] kernel/resource: Invalid memory access in __release_resource

2015-04-20 Thread Ricardo Ribalda Delgado
When a resource is initialized via of_platform_populate. resource->parent is initialized to NULL via kzalloc. (of_platform_populate->of_device_alloc->of_address_to_resource) If of_platform_depopulate is called later, resource->parent is accessed (Offset 0x30 of address 0), causing a kernel error.