On 15.07.2019 10:54, Petr Mladek wrote:
On Mon 2019-07-15 11:33:38, Sergey Senozhatsky wrote:
On (07/13/19 17:03), Konstantin Khlebnikov wrote:
We call kmsg_dump(KMSG_DUMP_PANIC) after smp_send_stop()
Indeed, panic is especially handled and looks fine.
Just to get a picture. What other situ
On Mon 2019-07-15 11:33:38, Sergey Senozhatsky wrote:
> On (07/13/19 17:03), Konstantin Khlebnikov wrote:
> > > We call kmsg_dump(KMSG_DUMP_PANIC) after smp_send_stop()
> >
> > Indeed, panic is especially handled and looks fine.
Just to get a picture. What other situations are we talking about,
p
On (07/15/19 10:38), Konstantin Khlebnikov wrote:
> > > Indeed, panic is especially handled and looks fine.
> > >
> > > Sanity check in my patch could be relaxed:
> > >
> > > if (WARN_ON_ONCE(reason != KMSG_DUMP_PANIC && in_nmi()))
> > > return;
> >
> > How critical kmsg_
On 15.07.2019 5:33, Sergey Senozhatsky wrote:
On (07/13/19 17:03), Konstantin Khlebnikov wrote:
We call kmsg_dump(KMSG_DUMP_PANIC) after smp_send_stop() and after
printk_safe_flush_on_panic(). printk_safe_flush_on_panic() resets
the state of logbuf_lock, so logbuf_lock, in general case, should
b
On (07/13/19 17:03), Konstantin Khlebnikov wrote:
> > We call kmsg_dump(KMSG_DUMP_PANIC) after smp_send_stop() and after
> > printk_safe_flush_on_panic(). printk_safe_flush_on_panic() resets
> > the state of logbuf_lock, so logbuf_lock, in general case, should
> > be unlocked by the time we call km
On Sat, Jul 13, 2019 at 4:20 PM Sergey Senozhatsky
wrote:
>
> On (07/13/19 09:46), Konstantin Khlebnikov wrote:
> > > On (07/12/19 17:54), Konstantin Khlebnikov wrote:
> >
> > Yep printk() can deal with NMI, but kmsg_dump() is a different beast.
> > It reads printk buffer and saves content into pe
On (07/13/19 09:46), Konstantin Khlebnikov wrote:
> > On (07/12/19 17:54), Konstantin Khlebnikov wrote:
>
> Yep printk() can deal with NMI, but kmsg_dump() is a different beast.
> It reads printk buffer and saves content into persistent storage like ACPI
> ERST.
Ah, sorry! I misread your patch.
On Sat, Jul 13, 2019 at 9:10 AM Sergey Senozhatsky
wrote:
>
> On (07/12/19 17:54), Konstantin Khlebnikov wrote:
> > Function kmsg_dump could be invoked from NMI context intentionally or
> > accidentally because it is called at various oops/panic paths.
> > Kernel message dumpers are not ready to w
On (07/12/19 17:54), Konstantin Khlebnikov wrote:
> Function kmsg_dump could be invoked from NMI context intentionally or
> accidentally because it is called at various oops/panic paths.
> Kernel message dumpers are not ready to work in NMI context right now.
> They could deadlock on lockbuf_lock o
Function kmsg_dump could be invoked from NMI context intentionally or
accidentally because it is called at various oops/panic paths.
Kernel message dumpers are not ready to work in NMI context right now.
They could deadlock on lockbuf_lock or break internal structures.
Theoretically some dumpers c
10 matches
Mail list logo
