Re: [PATCH] kernel/module.c: Free lock-classes if parse_args failed

2015-02-19 Thread Ingo Molnar
* Peter Zijlstra wrote: > > indeed ... > > How about something like so? It would fix this particular > issue and lays the groundwork for maybe reusing some of > the resources we now leak. > @@ -3916,6 +3926,20 @@ void lockdep_free_key_range(void *start, unsigned long > size) > if (loc

Re: [PATCH] kernel/module.c: Free lock-classes if parse_args failed

2015-02-19 Thread Peter Zijlstra
On Thu, Feb 19, 2015 at 01:12:33AM +0100, Ingo Molnar wrote: > > * Peter Zijlstra wrote: > > > On Tue, Jan 20, 2015 at 05:07:19PM +1030, Rusty Russell wrote: > > > Andrey Tsyvarev writes: > > > > parse_args call module parameters' .set handlers, which may use locks > > > > defined in the modul

Re: [PATCH] kernel/module.c: Free lock-classes if parse_args failed

2015-02-18 Thread Ingo Molnar
* Peter Zijlstra wrote: > On Tue, Jan 20, 2015 at 05:07:19PM +1030, Rusty Russell wrote: > > Andrey Tsyvarev writes: > > > parse_args call module parameters' .set handlers, which may use locks > > > defined in the module. > > > So, these classes should be freed in case parse_args returns error

Re: [PATCH] kernel/module.c: Free lock-classes if parse_args failed

2015-01-22 Thread Andrey Tsyvarev
22.01.2015 3:40, Rusty Russell пишет: Andrey Tsyvarev writes: 21.01.2015 4:40, Rusty Russell пишет: Andrey Tsyvarev writes: 20.01.2015 9:37, Rusty Russell пишет: Andrey Tsyvarev writes: parse_args call module parameters' .set handlers, which may use locks defined in the module. So, thes

Re: [PATCH] kernel/module.c: Free lock-classes if parse_args failed

2015-01-21 Thread Rusty Russell
Andrey Tsyvarev writes: > 21.01.2015 4:40, Rusty Russell пишет: >> Andrey Tsyvarev writes: >>> 20.01.2015 9:37, Rusty Russell пишет: Andrey Tsyvarev writes: > parse_args call module parameters' .set handlers, which may use locks > defined in the module. > So, these classes shou

Re: [PATCH] kernel/module.c: Free lock-classes if parse_args failed

2015-01-21 Thread Andrey Tsyvarev
21.01.2015 4:40, Rusty Russell пишет: Andrey Tsyvarev writes: 20.01.2015 9:37, Rusty Russell пишет: Andrey Tsyvarev writes: parse_args call module parameters' .set handlers, which may use locks defined in the module. So, these classes should be freed in case parse_args returns error(e.g. d

Re: [PATCH] kernel/module.c: Free lock-classes if parse_args failed

2015-01-20 Thread Rusty Russell
Andrey Tsyvarev writes: > 20.01.2015 9:37, Rusty Russell пишет: >> Andrey Tsyvarev writes: >>> parse_args call module parameters' .set handlers, which may use locks >>> defined in the module. >>> So, these classes should be freed in case parse_args returns error(e.g. due >>> to incorrect parame

Re: [PATCH] kernel/module.c: Free lock-classes if parse_args failed

2015-01-20 Thread Peter Zijlstra
On Tue, Jan 20, 2015 at 05:07:19PM +1030, Rusty Russell wrote: > Andrey Tsyvarev writes: > > parse_args call module parameters' .set handlers, which may use locks > > defined in the module. > > So, these classes should be freed in case parse_args returns error(e.g. due > > to incorrect parameter

Re: [PATCH] kernel/module.c: Free lock-classes if parse_args failed

2015-01-19 Thread Andrey Tsyvarev
20.01.2015 9:37, Rusty Russell пишет: Andrey Tsyvarev writes: parse_args call module parameters' .set handlers, which may use locks defined in the module. So, these classes should be freed in case parse_args returns error(e.g. due to incorrect parameter passed). Thanks, this seems right. Ap

Re: [PATCH] kernel/module.c: Free lock-classes if parse_args failed

2015-01-19 Thread Rusty Russell
Andrey Tsyvarev writes: > parse_args call module parameters' .set handlers, which may use locks defined > in the module. > So, these classes should be freed in case parse_args returns error(e.g. due > to incorrect parameter passed). Thanks, this seems right. Applied. But this makes me ask: wh

[PATCH] kernel/module.c: Free lock-classes if parse_args failed

2015-01-13 Thread Andrey Tsyvarev
parse_args call module parameters' .set handlers, which may use locks defined in the module. So, these classes should be freed in case parse_args returns error(e.g. due to incorrect parameter passed). Signed-off-by: Andrey Tsyvarev --- kernel/module.c | 3 +++ 1 file changed, 3 insertions(+)