[PATCH] kernel/module: Use BUG_ON instead of if condition followed by BUG.

2021-04-17 Thread zhouchuangao
First: This patch comes from cocinelle warning. Second: BUG_ON uses unlikely in if(). Through disassembly, we can see that brk #0x800 is compiled to the end of the function. As you can see below: .. ff8008660bec: d65f03c0ret ff8008660bf0: d421brk #0x800 Usu

Re: Re: [PATCH] kernel/module: Use BUG_ON instead of if condition followed by BUG.

2021-04-13 Thread Jessica Yu
+++ 周传高 [13/04/21 15:21 +0800]: +++ zhouchuangao [30/03/21 05:07 -0700]: It can be optimized at compile time. Signed-off-by: zhouchuangao Hi, Could you please provide a more descriptive changelog? I.e., Is this a fix for a cocinelle warning? What are the optimization(s)? Thanks, First,

Re:Re: [PATCH] kernel/module: Use BUG_ON instead of if condition followed by BUG.

2021-04-13 Thread 周传高
>+++ zhouchuangao [30/03/21 05:07 -0700]: >>It can be optimized at compile time. >> >>Signed-off-by: zhouchuangao > >Hi, > >Could you please provide a more descriptive changelog? I.e., Is this >a fix for a cocinelle warning? What are the optimization(s)? > >Thanks, > First, This patch comes from

Re: [PATCH] kernel/module: Use BUG_ON instead of if condition followed by BUG.

2021-04-12 Thread Jessica Yu
+++ zhouchuangao [30/03/21 05:07 -0700]: It can be optimized at compile time. Signed-off-by: zhouchuangao Hi, Could you please provide a more descriptive changelog? I.e., Is this a fix for a cocinelle warning? What are the optimization(s)? Thanks, Jessica --- kernel/module.c | 4 ++-- 1 f

[PATCH] kernel/module: Use BUG_ON instead of if condition followed by BUG.

2021-03-30 Thread zhouchuangao
It can be optimized at compile time. Signed-off-by: zhouchuangao --- kernel/module.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/module.c b/kernel/module.c index 3047935..f46fc4f 100644 --- a/kernel/module.c +++ b/kernel/module.c @@ -1014,8 +1014,8 @@ void __sy