Re: [PATCH] kernel/memremap: Remove stale devres_free() call

2018-03-06 Thread Dan Williams
On Tue, Mar 6, 2018 at 8:55 AM, Logan Gunthorpe wrote: > > > On 05/03/18 09:56 PM, Oliver O'Halloran wrote: >> >> devm_memremap_pages() was re-worked in e8d513483300 to take a caller >> allocated struct dev_pagemap as a function parameter. A call to >> devres_free() was left in the error cleanup p

Re: [PATCH] kernel/memremap: Remove stale devres_free() call

2018-03-06 Thread Logan Gunthorpe
On 05/03/18 09:56 PM, Oliver O'Halloran wrote: devm_memremap_pages() was re-worked in e8d513483300 to take a caller allocated struct dev_pagemap as a function parameter. A call to devres_free() was left in the error cleanup path which results in a kernel panic if the remap fails for some reason

Re: [PATCH] kernel/memremap: Remove stale devres_free() call

2018-03-06 Thread Christoph Hellwig
Looks good, Reviewed-by: Christoph Hellwig

[PATCH] kernel/memremap: Remove stale devres_free() call

2018-03-05 Thread Oliver O'Halloran
devm_memremap_pages() was re-worked in e8d513483300 to take a caller allocated struct dev_pagemap as a function parameter. A call to devres_free() was left in the error cleanup path which results in a kernel panic if the remap fails for some reason. Remove it to fix the panic and let devm_memremap_