Re: [PATCH] kernel/hung_task.c: disable on suspend

2018-09-21 Thread Vitaly Kuznetsov
"Rafael J. Wysocki" writes: > On Fri, Sep 21, 2018 at 3:11 PM Vitaly Kuznetsov wrote: >> >> Oleg Nesterov writes: >> >> > On 09/17, Rafael J. Wysocki wrote: >> >> >> >> On Fri, Sep 14, 2018 at 6:21 PM Oleg Nesterov wrote: >> >> > >> >> > > > Since you are adding the notifier anyway, what about

Re: [PATCH] kernel/hung_task.c: disable on suspend

2018-09-21 Thread Rafael J. Wysocki
On Fri, Sep 21, 2018 at 3:11 PM Vitaly Kuznetsov wrote: > > Oleg Nesterov writes: > > > On 09/17, Rafael J. Wysocki wrote: > >> > >> On Fri, Sep 14, 2018 at 6:21 PM Oleg Nesterov wrote: > >> > > >> > > > Since you are adding the notifier anyway, what about designing it to > >> > > > make > >> >

Re: [PATCH] kernel/hung_task.c: disable on suspend

2018-09-21 Thread Vitaly Kuznetsov
Oleg Nesterov writes: > On 09/17, Rafael J. Wysocki wrote: >> >> On Fri, Sep 14, 2018 at 6:21 PM Oleg Nesterov wrote: >> > >> > > > Since you are adding the notifier anyway, what about designing it to >> > > > make >> > > > the thread wait on _PREPARE until the notifier kicks it again on exit >

Re: [PATCH] kernel/hung_task.c: disable on suspend

2018-09-17 Thread Rafael J. Wysocki
On Mon, Sep 17, 2018 at 6:55 PM Oleg Nesterov wrote: > > On 09/17, Rafael J. Wysocki wrote: > > > > On Fri, Sep 14, 2018 at 6:21 PM Oleg Nesterov wrote: > > > > > > > > Since you are adding the notifier anyway, what about designing it to > > > > > make > > > > > the thread wait on _PREPARE until

Re: [PATCH] kernel/hung_task.c: disable on suspend

2018-09-17 Thread Oleg Nesterov
On 09/17, Rafael J. Wysocki wrote: > > On Fri, Sep 14, 2018 at 6:21 PM Oleg Nesterov wrote: > > > > > > Since you are adding the notifier anyway, what about designing it to > > > > make > > > > the thread wait on _PREPARE until the notifier kicks it again on exit > > > > fron suspend/hibernation?

Re: [PATCH] kernel/hung_task.c: disable on suspend

2018-09-17 Thread Rafael J. Wysocki
On Fri, Sep 14, 2018 at 6:21 PM Oleg Nesterov wrote: > > On 09/14, Vitaly Kuznetsov wrote: > > > > "Rafael J. Wysocki" writes: > > > > > On Thursday, September 13, 2018 6:08:51 PM CEST Vitaly Kuznetsov wrote: > > ... > > > > >> +static int hungtask_pm_notify(struct notifier_block *self, > > >> +

Re: [PATCH] kernel/hung_task.c: disable on suspend

2018-09-14 Thread Oleg Nesterov
On 09/14, Vitaly Kuznetsov wrote: > > "Rafael J. Wysocki" writes: > > > On Thursday, September 13, 2018 6:08:51 PM CEST Vitaly Kuznetsov wrote: > ... > > >> +static int hungtask_pm_notify(struct notifier_block *self, > >> +unsigned long action, void *hcpu) > >> +{ > >> +

Re: [PATCH] kernel/hung_task.c: disable on suspend

2018-09-14 Thread Vitaly Kuznetsov
"Rafael J. Wysocki" writes: > On Thursday, September 13, 2018 6:08:51 PM CEST Vitaly Kuznetsov wrote: ... >> +static int hungtask_pm_notify(struct notifier_block *self, >> + unsigned long action, void *hcpu) >> +{ >> +switch (action) { >> +case PM_SUSPEND_PREPARE

Re: [PATCH] kernel/hung_task.c: disable on suspend

2018-09-14 Thread Rafael J. Wysocki
On Thursday, September 13, 2018 6:08:51 PM CEST Vitaly Kuznetsov wrote: > It is possible to observe hung_task complaints when system goes to > suspend-to-idle state: > > PM: Syncing filesystems ... done. > Freezing user space processes ... (elapsed 0.001 seconds) done. > OOM killer disabled. >

[PATCH] kernel/hung_task.c: disable on suspend

2018-09-13 Thread Vitaly Kuznetsov
It is possible to observe hung_task complaints when system goes to suspend-to-idle state: PM: Syncing filesystems ... done. Freezing user space processes ... (elapsed 0.001 seconds) done. OOM killer disabled. Freezing remaining freezable tasks ... (elapsed 0.002 seconds) done. sd 0:0:0:0: [sd