Re: [PATCH] kernel/debug/kdb: code enhancement for 3 areas.

2013-05-27 Thread Chen Gang
On 05/24/2013 09:18 AM, Chen Gang wrote: > On 05/24/2013 01:28 AM, Anton Vorontsov wrote: >> > On Thu, May 16, 2013 at 07:25:46PM +0800, Chen Gang wrote: >> > Delete waste '{' for 'case' statement. >> > >> > For the return variable 'long res' in function >> > kdb_task_state_st

Re: [PATCH] kernel/debug/kdb: code enhancement for 3 areas.

2013-05-23 Thread Chen Gang
On 05/24/2013 01:28 AM, Anton Vorontsov wrote: > On Thu, May 16, 2013 at 07:25:46PM +0800, Chen Gang wrote: >> > Delete waste '{' for 'case' statement. >> > >> > For the return variable 'long res' in function kdb_task_state_string(), >> > neither it matches the function return type 'unsigned long'

Re: [PATCH] kernel/debug/kdb: code enhancement for 3 areas.

2013-05-23 Thread Anton Vorontsov
On Thu, May 16, 2013 at 07:25:46PM +0800, Chen Gang wrote: > Delete waste '{' for 'case' statement. > > For the return variable 'long res' in function kdb_task_state_string(), > neither it matches the function return type 'unsigned long', nor is > suitable as a flag variable to make 'or' operation

[PATCH] kernel/debug/kdb: code enhancement for 3 areas.

2013-05-16 Thread Chen Gang
Delete waste '{' for 'case' statement. For the return variable 'long res' in function kdb_task_state_string(), neither it matches the function return type 'unsigned long', nor is suitable as a flag variable to make 'or' operation. So use 'unsigned long' instead of 'long'. If "case 'A'" happen in