Re: [PATCH] kdump: Fix gdb macros work work with newer and 64-bit kernels

2016-05-09 Thread Baoquan He
Hi Corey, On 05/09/16 at 07:10am, Corey Minyard wrote: > >>>diff --git a/Documentation/kdump/gdbmacros.txt > >>>b/Documentation/kdump/gdbmacros.txt > >>>index 9b9b454..e5bbd8d 100644 > >>>--- a/Documentation/kdump/gdbmacros.txt > >>>+++ b/Documentation/kdump/gdbmacros.txt > >>>@@ -54,42 +54,43 @@

Re: [PATCH] kdump: Fix gdb macros work work with newer and 64-bit kernels

2016-05-09 Thread Baoquan He
On 05/09/16 at 10:40am, Corey Minyard wrote: > > define bttnobp > > set $tasks_off=((size_t)&((struct task_struct *)0)->tasks) > >-set $pid_off=((size_t)&((struct task_struct > >*)0)->pids[1].pid_list.next) > >+set $pid_off=((size_t)&((struct task_struc

Re: [PATCH] kdump: Fix gdb macros work work with newer and 64-bit kernels

2016-05-09 Thread Corey Minyard
On 05/09/2016 09:29 AM, Baoquan He wrote: On 05/09/16 at 07:10am, Corey Minyard wrote: On 05/09/2016 12:18 AM, Baoquan He wrote: Hi Corey, I am trying to review this patch now, and these fixes contained are very great. Just several concerns are added in inline comment. By the way, did you run

Re: [PATCH] kdump: Fix gdb macros work work with newer and 64-bit kernels

2016-05-09 Thread Baoquan He
On 05/09/16 at 07:10am, Corey Minyard wrote: > On 05/09/2016 12:18 AM, Baoquan He wrote: > >Hi Corey, > > > >I am trying to review this patch now, and these fixes contained are very > >great. Just several concerns are added in inline comment. > > > >By the way, did you run this in your side? > > Y

Re: [PATCH] kdump: Fix gdb macros work work with newer and 64-bit kernels

2016-05-09 Thread Corey Minyard
On 05/09/2016 12:18 AM, Baoquan He wrote: Hi Corey, I am trying to review this patch now, and these fixes contained are very great. Just several concerns are added in inline comment. By the way, did you run this in your side? Yes, I tested on x86, x86_64, ARM and MIPS. Comments inline...

Re: [PATCH] kdump: Fix gdb macros work work with newer and 64-bit kernels

2016-05-08 Thread Baoquan He
Hi Corey, I am trying to review this patch now, and these fixes contained are very great. Just several concerns are added in inline comment. By the way, did you run this in your side? Hi Vivek, Member variable was added into task_struct in below commit replacing pids[PIDTYPE_TGID], and from the

Re: [PATCH] kdump: Fix gdb macros work work with newer and 64-bit kernels

2016-05-04 Thread Baoquan He
On 04/27/16 at 07:21am, Corey Minyard wrote: > Any comments on this? If no one else cares I'd be willing to take over > maintenance of this. Vivek is busy with some other issues. He asked Dave and me to test and review this patch. Will check this recently. Thanks Baoquan > > -corey > > On 02/

Re: [PATCH] kdump: Fix gdb macros work work with newer and 64-bit kernels

2016-04-27 Thread Corey Minyard
Any comments on this? If no one else cares I'd be willing to take over maintenance of this. -corey On 02/25/2016 07:51 AM, miny...@acm.org wrote: From: Corey Minyard Lots of little changes needed to be made to clean these up, remove the four byte pointer assumption and traverse the pid queue

[PATCH] kdump: Fix gdb macros work work with newer and 64-bit kernels

2016-02-25 Thread minyard
From: Corey Minyard Lots of little changes needed to be made to clean these up, remove the four byte pointer assumption and traverse the pid queue properly. Also consolidate the traceback code into a single function instead of having three copies of it. Signed-off-by: Corey Minyard --- Documen