Re: [PATCH] kconfig: Print reverse dependencies in groups

2018-02-21 Thread Ulf Magnusson
On Wed, Feb 21, 2018 at 12:17 PM, Petr Vorel wrote: > Hi Masahiro, > >> > Signed-off-by: Masahiro Yamada >> Acked-by: Petr Vorel > Well, I'm not really the one to ack anything here, so please: > Reviewed-by: Petr Vorel > > Kind regards, > Petr Looks good to me too. Reviewed-by: Ulf Magnusson

Re: [PATCH] kconfig: Print reverse dependencies in groups

2018-02-21 Thread Petr Vorel
Hi Masahiro, > > Signed-off-by: Masahiro Yamada > Acked-by: Petr Vorel Well, I'm not really the one to ack anything here, so please: Reviewed-by: Petr Vorel Kind regards, Petr

Re: [PATCH] kconfig: Print reverse dependencies in groups

2018-02-21 Thread Petr Vorel
Hi Masahiro, > Signed-off-by: Masahiro Yamada Acked-by: Petr Vorel Just please fix typo leading to segfault and add ':' > get_symbol_props_str(r, sym, P_SELECT, _(" Selects: ")); > if (sym->rev_dep.expr) { > - str_append(r, _(" Selected by: \n")); > - expr

[PATCH] kconfig: Print reverse dependencies in groups

2018-02-20 Thread Masahiro Yamada
Signed-off-by: Masahiro Yamada --- This patch requires the following as a pre-requisite: https://patchwork.kernel.org/patch/10229545/ These two will work equivalently to the following three: https://patchwork.kernel.org/patch/10226951/ https://patchwork.kernel.org/patch/10226953/ https://patchw