Re: [PATCH] kbuild: simplify access to the kernel's version

2021-02-12 Thread Sasha Levin
On Fri, Feb 12, 2021 at 12:41:21PM +0900, Masahiro Yamada wrote: Please send a correct patch, also drop the unneeded casts. Sorry about that, I've hand edited the patch right before sending it out and obviously messed it up. I'll resend. -- Thanks, Sasha

Re: [PATCH] kbuild: simplify access to the kernel's version

2021-02-11 Thread Masahiro Yamada
On Fri, Feb 12, 2021 at 12:40 PM Masahiro Yamada wrote: > > On Fri, Feb 12, 2021 at 5:18 AM Masahiro Yamada wrote: > > > > On Tue, Feb 9, 2021 at 3:20 AM Sasha Levin wrote: > > > > > > On Mon, Feb 08, 2021 at 05:50:07PM +, Christoph Hellwig wrote: > > > >On Sun, Feb 07, 2021 at 11:13:52AM -0

Re: [PATCH] kbuild: simplify access to the kernel's version

2021-02-11 Thread Masahiro Yamada
On Fri, Feb 12, 2021 at 5:18 AM Masahiro Yamada wrote: > > On Tue, Feb 9, 2021 at 3:20 AM Sasha Levin wrote: > > > > On Mon, Feb 08, 2021 at 05:50:07PM +, Christoph Hellwig wrote: > > >On Sun, Feb 07, 2021 at 11:13:52AM -0500, Sasha Levin wrote: > > >> +(u8)(LINUX_VERSION_MAJOR),

Re: [PATCH] kbuild: simplify access to the kernel's version

2021-02-11 Thread Masahiro Yamada
On Tue, Feb 9, 2021 at 3:20 AM Sasha Levin wrote: > > On Mon, Feb 08, 2021 at 05:50:07PM +, Christoph Hellwig wrote: > >On Sun, Feb 07, 2021 at 11:13:52AM -0500, Sasha Levin wrote: > >> +(u8)(LINUX_VERSION_MAJOR), (u8)(LINUX_VERSION_PATCHLEVEL), > >> +(u16)(LINUX_VERSIO

Re: [PATCH] kbuild: simplify access to the kernel's version

2021-02-08 Thread Sasha Levin
On Mon, Feb 08, 2021 at 05:50:07PM +, Christoph Hellwig wrote: On Sun, Feb 07, 2021 at 11:13:52AM -0500, Sasha Levin wrote: + (u8)(LINUX_VERSION_MAJOR), (u8)(LINUX_VERSION_PATCHLEVEL), + (u16)(LINUX_VERSION_SUBLEVEL)); No need for the casts and braces. Otherwis

Re: [PATCH] kbuild: simplify access to the kernel's version

2021-02-08 Thread Christoph Hellwig
On Sun, Feb 07, 2021 at 11:13:52AM -0500, Sasha Levin wrote: > + (u8)(LINUX_VERSION_MAJOR), (u8)(LINUX_VERSION_PATCHLEVEL), > + (u16)(LINUX_VERSION_SUBLEVEL)); No need for the casts and braces. Otherwise this looks good, but please also kill off KERNEL_VERSION and LINUX_KE

Re: [PATCH] kbuild: simplify access to the kernel's version

2021-02-07 Thread Greg KH
On Sun, Feb 07, 2021 at 11:13:52AM -0500, Sasha Levin wrote: > Instead of storing the version in a single integer and having various > kernel (and userspace) code how it's constructed, export individual > (major, patchlevel, sublevel) components and simplify kernel code that > uses it. > > This sh

[PATCH] kbuild: simplify access to the kernel's version

2021-02-07 Thread Sasha Levin
Instead of storing the version in a single integer and having various kernel (and userspace) code how it's constructed, export individual (major, patchlevel, sublevel) components and simplify kernel code that uses it. This should also make it easier on userspace. Signed-off-by: Sasha Levin ---