Re: [PATCH] kbuild: clang: Disable -Wunused-const-variable warnings

2018-02-02 Thread Masahiro Yamada
2018-01-30 2:08 GMT+09:00 Prasad Sodagudi : > Currently -Wunused-variable warnings are disabled with > clang and with gcc -Wunused-variable warnings are > enabled, with this setting all unused local variables > would be warned in clang as well. > > Disable -Wunused-const-variable warnings instead o

Re: [PATCH] kbuild: clang: Disable -Wunused-const-variable warnings

2018-01-29 Thread Segher Boessenkool
Hi Prasad, On Mon, Jan 29, 2018 at 09:08:00AM -0800, Prasad Sodagudi wrote: > --- a/Makefile > +++ b/Makefile > @@ -698,7 +698,6 @@ KBUILD_CFLAGS += $(stackp-flag) > > ifeq ($(cc-name),clang) > KBUILD_CPPFLAGS += $(call cc-option,-Qunused-arguments,) > -KBUILD_CFLAGS += $(call cc-disable-warni

[PATCH] kbuild: clang: Disable -Wunused-const-variable warnings

2018-01-29 Thread Prasad Sodagudi
Currently -Wunused-variable warnings are disabled with clang and with gcc -Wunused-variable warnings are enabled, with this setting all unused local variables would be warned in clang as well. Disable -Wunused-const-variable warnings instead of disabling -Wunused-variable warnings, So that in both

Re: [PATCH] kbuild: clang: Disable -Wunused-const-variable warnings

2018-01-29 Thread Sodagudi Prasad
On 2018-01-28 08:22, Segher Boessenkool wrote: On Fri, Jan 26, 2018 at 04:59:46PM -0800, Prasad Sodagudi wrote: Disable -Wunused-const-variable warnings instead of disabling -Wunused-variable warnings, So that in both clang and GCC -Wunused-const-variable gets disabled. Why would you disable -

Re: [PATCH] kbuild: clang: Disable -Wunused-const-variable warnings

2018-01-28 Thread Segher Boessenkool
On Fri, Jan 26, 2018 at 04:59:46PM -0800, Prasad Sodagudi wrote: > Disable -Wunused-const-variable warnings instead of > disabling -Wunused-variable warnings, So that in both > clang and GCC -Wunused-const-variable gets disabled. Why would you disable -Wunused-const-variable on GCC? You do not ex

[PATCH] kbuild: clang: Disable -Wunused-const-variable warnings

2018-01-26 Thread Prasad Sodagudi
Disable -Wunused-const-variable warnings instead of disabling -Wunused-variable warnings, So that in both clang and GCC -Wunused-const-variable gets disabled. Currently with clang -Wunused-variable warnings are disabled and with gcc -Wunused-variable warnings are enabled, with this setting all unu