Re: [PATCH] kasan: fix slab double free when cpu-hotplug

2020-12-11 Thread Andrew Morton
On Fri, 11 Dec 2020 13:43:39 + Chris Down wrote: > Hi folks, > > Andrew Morton writes: > >@@ -188,6 +190,10 @@ void quarantine_put(struct kasan_free_me > > local_irq_save(flags); > > > > q = this_cpu_ptr(&cpu_quarantine); > >+if (q->offline) { > >+local_irq_restore(fl

Re: [PATCH] kasan: fix slab double free when cpu-hotplug

2020-12-11 Thread Chris Down
Hi folks, Andrew Morton writes: @@ -188,6 +190,10 @@ void quarantine_put(struct kasan_free_me local_irq_save(flags); q = this_cpu_ptr(&cpu_quarantine); + if (q->offline) { + local_irq_restore(flags); + return; + } qlist_put(q, &inf

Re: [PATCH] kasan: fix slab double free when cpu-hotplug

2020-12-06 Thread Kuan-Ying Lee
On Mon, 2020-12-07 at 10:06 +0800, Kuan-Ying Lee wrote: > On Sat, 2020-12-05 at 17:09 -0800, Andrew Morton wrote: > > On Sun, 6 Dec 2020 00:17:15 +0800 Kuan-Ying Lee > > wrote: > > > > > On Fri, 2020-12-04 at 17:25 -0800, Andrew Morton wrote: > > > > On Fri, 4 Dec 2020 20:01:35 +0800 Kuan-Ying L

Re: [PATCH] kasan: fix slab double free when cpu-hotplug

2020-12-06 Thread Kuan-Ying Lee
On Sat, 2020-12-05 at 17:09 -0800, Andrew Morton wrote: > On Sun, 6 Dec 2020 00:17:15 +0800 Kuan-Ying Lee > wrote: > > > On Fri, 2020-12-04 at 17:25 -0800, Andrew Morton wrote: > > > On Fri, 4 Dec 2020 20:01:35 +0800 Kuan-Ying Lee > > > wrote: > > > > > > > > diff --git a/mm/kasan/quarantine.

Re: [PATCH] kasan: fix slab double free when cpu-hotplug

2020-12-05 Thread Andrew Morton
On Sun, 6 Dec 2020 00:17:15 +0800 Kuan-Ying Lee wrote: > On Fri, 2020-12-04 at 17:25 -0800, Andrew Morton wrote: > > On Fri, 4 Dec 2020 20:01:35 +0800 Kuan-Ying Lee > > wrote: > > > > > > diff --git a/mm/kasan/quarantine.c b/mm/kasan/quarantine.c > > > > index d98b516f372f..55783125a767 10064

Re: [PATCH] kasan: fix slab double free when cpu-hotplug

2020-12-05 Thread Kuan-Ying Lee
On Fri, 2020-12-04 at 17:25 -0800, Andrew Morton wrote: > On Fri, 4 Dec 2020 20:01:35 +0800 Kuan-Ying Lee > wrote: > > > > diff --git a/mm/kasan/quarantine.c b/mm/kasan/quarantine.c > > > index d98b516f372f..55783125a767 100644 > > > --- a/mm/kasan/quarantine.c > > > +++ b/mm/kasan/quarantine.c

Re: [PATCH] kasan: fix slab double free when cpu-hotplug

2020-12-04 Thread Andrew Morton
On Fri, 4 Dec 2020 20:01:35 +0800 Kuan-Ying Lee wrote: > > diff --git a/mm/kasan/quarantine.c b/mm/kasan/quarantine.c > > index d98b516f372f..55783125a767 100644 > > --- a/mm/kasan/quarantine.c > > +++ b/mm/kasan/quarantine.c > > @@ -194,7 +194,6 @@ bool quarantine_put(struct kmem_cache *cache,

Re: [PATCH] kasan: fix slab double free when cpu-hotplug

2020-12-04 Thread Kuan-Ying Lee
On Fri, 2020-12-04 at 18:22 +0800, qiang.zh...@windriver.com wrote: > From: Zqiang > > When a CPU offline, the per-cpu quarantine's offline be set true, > after this, if the quarantine_put be called in this CPU, the objects > will be free and return false, free objects doesn't to be done, due > t

[PATCH] kasan: fix slab double free when cpu-hotplug

2020-12-04 Thread qiang . zhang
From: Zqiang When a CPU offline, the per-cpu quarantine's offline be set true, after this, if the quarantine_put be called in this CPU, the objects will be free and return false, free objects doesn't to be done, due to return false, the slab memory manager will free this objects. Fixes: 41ab1aae