Re: [PATCH] kasan: convert kasan/quarantine_lock to raw_spinlock

2018-10-10 Thread Dmitry Vyukov
On Wed, Oct 10, 2018 at 11:53 AM, Sebastian Andrzej Siewior wrote: > On 2018-10-10 11:45:32 [+0200], Dmitry Vyukov wrote: >> > Should I repost Clark's patch? >> >> >> I am much more comfortable with just changing the type of the lock. > > Yes, that is what Clark's patch does. Should I resent it?

Re: [PATCH] kasan: convert kasan/quarantine_lock to raw_spinlock

2018-10-10 Thread Sebastian Andrzej Siewior
On 2018-10-10 11:45:32 [+0200], Dmitry Vyukov wrote: > > Should I repost Clark's patch? > > > I am much more comfortable with just changing the type of the lock. Yes, that is what Clark's patch does. Should I resent it? > What are the bad implications of using the raw spinlock? Will it help > t

Re: [PATCH] kasan: convert kasan/quarantine_lock to raw_spinlock

2018-10-10 Thread Dmitry Vyukov
On Wed, Oct 10, 2018 at 11:29 AM, Sebastian Andrzej Siewior wrote: > On 2018-10-10 10:25:42 [+0200], Dmitry Vyukov wrote: >> > That loop should behave like your on_each_cpu() except it does not >> > involve the remote CPU. >> >> >> The problem is that it can squeeze in between: >> >> +

Re: [PATCH] kasan: convert kasan/quarantine_lock to raw_spinlock

2018-10-10 Thread Sebastian Andrzej Siewior
On 2018-10-10 10:25:42 [+0200], Dmitry Vyukov wrote: > > That loop should behave like your on_each_cpu() except it does not > > involve the remote CPU. > > > The problem is that it can squeeze in between: > > + spin_unlock(&q->lock); > > spin_lock(&quarantine_lock)

Re: [PATCH] kasan: convert kasan/quarantine_lock to raw_spinlock

2018-10-10 Thread Dmitry Vyukov
On Tue, Oct 9, 2018 at 4:27 PM, Sebastian Andrzej Siewior wrote: > On 2018-10-08 11:15:57 [+0200], Dmitry Vyukov wrote: >> Hi Sebastian, > Hi Dmitry, > >> This seems to beak quarantine_remove_cache( ) in the sense that some >> object from the cache may still be in quarantine when >> quarantine_rem

Re: [PATCH] kasan: convert kasan/quarantine_lock to raw_spinlock

2018-10-09 Thread Sebastian Andrzej Siewior
On 2018-10-08 11:15:57 [+0200], Dmitry Vyukov wrote: > Hi Sebastian, Hi Dmitry, > This seems to beak quarantine_remove_cache( ) in the sense that some > object from the cache may still be in quarantine when > quarantine_remove_cache() returns. When quarantine_remove_cache() > returns all objects f

Re: [PATCH] kasan: convert kasan/quarantine_lock to raw_spinlock

2018-10-08 Thread Dmitry Vyukov
On Fri, Oct 5, 2018 at 6:33 PM, Sebastian Andrzej Siewior wrote: > On 2018-10-05 18:30:18 [+0200], To Clark Williams wrote: >> This is the minimum to get this working on RT splat free. There is one >> memory deallocation with irqs off which should work on RT in its current >> way. >> Once this and

Re: [PATCH] kasan: convert kasan/quarantine_lock to raw_spinlock

2018-10-07 Thread Clark Williams
I applied this patch to a fairly stock 4.18-rt5 kernel and booted with no complaints, then ran rteval for 12h with no stack splats reported. I'll keep banging on it but preliminary reports look good. Clark On Fri, 5 Oct 2018 18:33:20 +0200 Sebastian Andrzej Siewior wrote: > On 2018-10-05 18:

Re: [PATCH] kasan: convert kasan/quarantine_lock to raw_spinlock

2018-10-05 Thread Sebastian Andrzej Siewior
On 2018-10-05 18:30:18 [+0200], To Clark Williams wrote: > This is the minimum to get this working on RT splat free. There is one > memory deallocation with irqs off which should work on RT in its current > way. > Once this and the on_each_cpu() invocation, I was wondering if… the patch at the bot

Re: [PATCH] kasan: convert kasan/quarantine_lock to raw_spinlock

2018-10-05 Thread Sebastian Andrzej Siewior
On 2018-09-18 10:29:31 [-0500], Clark Williams wrote: So I received this from Clark: > The static lock quarantine_lock is used in mm/kasan/quarantine.c to protect > the quarantine queue datastructures. It is taken inside quarantine queue > manipulation routines (quarantine_put(), quarantine_reduc