Re: [PATCH] irqdomain: provide useful debugging information for irq domain

2018-01-18 Thread Yang, Shunyong
Hi, Marc On Thu, 2018-01-18 at 08:54 +, Marc Zyngier wrote: > On 18/01/18 01:53, Yang, Shunyong wrote: > > > > Hi, Marc > > > > On Wed, 2018-01-17 at 10:43 +, Marc Zyngier wrote: > > > > > > On 17/01/18 10:20, Yang, Shunyong wrote: > > > > > > > > > > > > Hi, Thomas and Marc, > > > >

Re: [PATCH] irqdomain: provide useful debugging information for irq domain

2018-01-18 Thread Marc Zyngier
On 18/01/18 01:53, Yang, Shunyong wrote: > Hi, Marc > > On Wed, 2018-01-17 at 10:43 +, Marc Zyngier wrote: >> On 17/01/18 10:20, Yang, Shunyong wrote: >>> >>> Hi, Thomas and Marc, >>> >>> On Wed, 2018-01-17 at 11:01 +0100, Thomas Gleixner wrote: On Wed, 17 Jan 2018, Yang, Shunyong wr

Re: [PATCH] irqdomain: provide useful debugging information for irq domain

2018-01-17 Thread Yang, Shunyong
Hi, Marc On Wed, 2018-01-17 at 10:43 +, Marc Zyngier wrote: > On 17/01/18 10:20, Yang, Shunyong wrote: > > > > Hi, Thomas and Marc, > > > > On Wed, 2018-01-17 at 11:01 +0100, Thomas Gleixner wrote: > > > > > > On Wed, 17 Jan 2018, Yang, Shunyong wrote: > > > > > > > > > > > > On Wed, 2018

Re: [PATCH] irqdomain: provide useful debugging information for irq domain

2018-01-17 Thread Marc Zyngier
On 17/01/18 10:20, Yang, Shunyong wrote: > Hi, Thomas and Marc, > > On Wed, 2018-01-17 at 11:01 +0100, Thomas Gleixner wrote: >> On Wed, 17 Jan 2018, Yang, Shunyong wrote: >>> >>> On Wed, 2018-01-17 at 10:33 +0100, Thomas Gleixner wrote: And how is that different from: > > >

Re: Re: Re: [PATCH] irqdomain: provide useful debugging information for irq domain

2018-01-17 Thread Thomas Gleixner
On Wed, 17 Jan 2018, Yang, Shunyong wrote: > On Wed, 2018-01-17 at 11:01 +0100, Thomas Gleixner wrote: > > You can retrieve the same information from the irq/irqs files. All it > > takes > > is a shell script. > > > > Aside of that with hierarchical irq domains the old debug output is > > just > >

Re: Re: Re: [PATCH] irqdomain: provide useful debugging information for irq domain

2018-01-17 Thread Yang, Shunyong
Hi, Thomas and Marc, On Wed, 2018-01-17 at 11:01 +0100, Thomas Gleixner wrote: > On Wed, 17 Jan 2018, Yang, Shunyong wrote: > > > > On Wed, 2018-01-17 at 10:33 +0100, Thomas Gleixner wrote: > > > > > > And how is that different from: > > > > > > > > > > > > > > > The nodes under debugfs irq/i

Re: [此邮件可能存在风险] Re: [PATCH] irqdomain: provide useful debugging information for irq domain

2018-01-17 Thread Marc Zyngier
On 17/01/18 09:47, Yang, Shunyong wrote: > Hi, Thomas, > > On Wed, 2018-01-17 at 10:33 +0100, Thomas Gleixner wrote: >> On Wed, 17 Jan 2018, Yang, Shunyong wrote: >> >>> >>> Hi, Marc and Thomas, >>> >>> Thanks for your feedback. >>> >>> On Wed, 2018-01-17 at 10:18 +0100, Thomas Gleixner wrote: >>>

Re: [PATCH] irqdomain: provide useful debugging information for irq domain

2018-01-17 Thread Thomas Gleixner
On Wed, 17 Jan 2018, Yang, Shunyong wrote: > Hi, Marc and Thomas, > > Thanks for your feedback. > > On Wed, 2018-01-17 at 10:18 +0100, Thomas Gleixner wrote: > > On Wed, 17 Jan 2018, Marc Zyngier wrote: > > > > > > In all honesty, I'd be more inclined to remove this debug feature > > > altogeth

Re: [PATCH] irqdomain: provide useful debugging information for irq domain

2018-01-17 Thread Yang, Shunyong
Hi, Marc and Thomas, Thanks for your feedback. On Wed, 2018-01-17 at 10:18 +0100, Thomas Gleixner wrote: > On Wed, 17 Jan 2018, Marc Zyngier wrote: > > > > In all honesty, I'd be more inclined to remove this debug feature > > altogether, as CONFIG_GENERIC_IRQ_DEBUGFS is more complete and more >

Re: [PATCH] irqdomain: provide useful debugging information for irq domain

2018-01-17 Thread Marc Zyngier
On 17/01/18 09:18, Thomas Gleixner wrote: > On Wed, 17 Jan 2018, Marc Zyngier wrote: >> In all honesty, I'd be more inclined to remove this debug feature >> altogether, as CONFIG_GENERIC_IRQ_DEBUGFS is more complete and more >> useful. Is there any feature missing from that infrastructure that >> p

Re: [PATCH] irqdomain: provide useful debugging information for irq domain

2018-01-17 Thread Thomas Gleixner
On Wed, 17 Jan 2018, Marc Zyngier wrote: > In all honesty, I'd be more inclined to remove this debug feature > altogether, as CONFIG_GENERIC_IRQ_DEBUGFS is more complete and more > useful. Is there any feature missing from that infrastructure that > prevents you from using it instead? > > If the a

Re: [PATCH] irqdomain: provide useful debugging information for irq domain

2018-01-17 Thread Marc Zyngier
Hi Yang, On 17/01/18 04:37, Yang Shunyong wrote: > With recent hashed kernel pointers change, output with %p will > output hashed address. This patch changes %p to %px in irq domain > debug information. As unprivileged user has no permission to mount > debugfs or set printk level to KERN_DEBUG to

[PATCH] irqdomain: provide useful debugging information for irq domain

2018-01-16 Thread Yang Shunyong
With recent hashed kernel pointers change, output with %p will output hashed address. This patch changes %p to %px in irq domain debug information. As unprivileged user has no permission to mount debugfs or set printk level to KERN_DEBUG to access the information, changes in this patch are appropri