Re: [PATCH] irqdomain: Fix NULL pointer dererence in irq_domain_free_irqs_parent

2014-11-20 Thread Suravee Suthikulpanit
On 11/20/2014 08:49 PM, Jiang Liu wrote: On 2014/11/21 10:08, Suravee Suthikulpanit wrote: On 11/20/2014 07:32 PM, Thomas Gleixner wrote: On Thu, 20 Nov 2014, suravee.suthikulpa...@amd.com wrote: This patch checks if the parent domain is NULL before recursively freeing irqs in the parent d

Re: [PATCH] irqdomain: Fix NULL pointer dererence in irq_domain_free_irqs_parent

2014-11-20 Thread Jiang Liu
On 2014/11/21 10:08, Suravee Suthikulpanit wrote: > On 11/20/2014 07:32 PM, Thomas Gleixner wrote: >> On Thu, 20 Nov 2014, suravee.suthikulpa...@amd.com wrote: >>> This patch checks if the parent domain is NULL before recursively >>> freeing >>> irqs in the parent domains. >> >> Which is nonsense

Re: [PATCH] irqdomain: Fix NULL pointer dererence in irq_domain_free_irqs_parent

2014-11-20 Thread Suravee Suthikulpanit
On 11/20/2014 07:32 PM, Thomas Gleixner wrote: On Thu, 20 Nov 2014, suravee.suthikulpa...@amd.com wrote: This patch checks if the parent domain is NULL before recursively freeing irqs in the parent domains. Which is nonsense, because if the thing has not been allocated in the first place, then

Re: [PATCH] irqdomain: Fix NULL pointer dererence in irq_domain_free_irqs_parent

2014-11-20 Thread Thomas Gleixner
On Thu, 20 Nov 2014, suravee.suthikulpa...@amd.com wrote: > This patch checks if the parent domain is NULL before recursively freeing > irqs in the parent domains. Which is nonsense, because if the thing has not been allocated in the first place, then it cannot explode in the free path magically,

[PATCH] irqdomain: Fix NULL pointer dererence in irq_domain_free_irqs_parent

2014-11-20 Thread suravee.suthikulpanit
From: Suravee Suthikulpanit This patch checks if the parent domain is NULL before recursively freeing irqs in the parent domains. In this case, GICv2m is freeing irqs in parent (GIC), which calls irq_domain_free_irqs_top. This fixes the crash below: Unble to handle kernel NULL pointer dereferen