Re: [PATCH] irqchip: gic-v3: Explicitly include linux/io.h

2015-08-19 Thread Ben Zhang
This patch is not really needed. The build failure on our v3.18-based kernel is fixed by cherry-picking commit 332fd7c4fef5 ("genirq: Generic chip: Change irq_reg_{readl,writel} arguments") which is actually a functional no-op. This patch could help prevent future build failure in case linux/io.h i

Re: [PATCH] irqchip: gic-v3: Explicitly include linux/io.h

2015-08-19 Thread Thomas Gleixner
On Fri, 7 Aug 2015, Ben Zhang wrote: > Mainline build is fine because commit 332fd7c4fef5("genirq: Generic > chip: Change irq_reg_{readl,writel} arguments") landed before the > timecounter patch, and it creates a new include path to the io.h > header: > arch/arm64/include/asm/io.h > include/linux/i

Re: [PATCH] irqchip: gic-v3: Explicitly include linux/io.h

2015-08-07 Thread Ben Zhang
On Fri, Aug 7, 2015 at 1:40 AM, Marc Zyngier wrote: > Hi Ben, > > On 07/08/15 06:31, Ben Zhang wrote: >> linux/io.h is needed because the driver uses: >> readl_relaxed >> writel_relaxed >> writeq_relaxed >> readq_relaxed >> iounmap >> >> The header was implicitly included by an unrelated >> commit

Re: [PATCH] irqchip: gic-v3: Explicitly include linux/io.h

2015-08-07 Thread Marc Zyngier
Hi Ben, On 07/08/15 06:31, Ben Zhang wrote: > linux/io.h is needed because the driver uses: > readl_relaxed > writel_relaxed > writeq_relaxed > readq_relaxed > iounmap > > The header was implicitly included by an unrelated > commit 332fd7c4fef5 > ("genirq: Generic chip: Change irq_reg_{readl,writ

[PATCH] irqchip: gic-v3: Explicitly include linux/io.h

2015-08-06 Thread Ben Zhang
linux/io.h is needed because the driver uses: readl_relaxed writel_relaxed writeq_relaxed readq_relaxed iounmap The header was implicitly included by an unrelated commit 332fd7c4fef5 ("genirq: Generic chip: Change irq_reg_{readl,writel} arguments") from the path below: include/linux/io.h include/l