Re: [PATCH] irqchip: bcm7120-l2: fix error handling of irq_of_parse_and_map

2014-11-25 Thread Jason Cooper
On Fri, Nov 14, 2014 at 02:16:14PM -0800, Dmitry Torokhov wrote: > Return value of irq_of_parse_and_map() is unsigned int, with 0 > indicating failure, so testing for negative result never works. > > Signed-off-by: Dmitry Torokhov > --- > > Not tested, found by casual code inspection. > > driv

Re: [PATCH] irqchip: bcm7120-l2: fix error handling of irq_of_parse_and_map

2014-11-15 Thread Kevin Cernekee
On Fri, Nov 14, 2014 at 2:16 PM, Dmitry Torokhov wrote: > Return value of irq_of_parse_and_map() is unsigned int, with 0 > indicating failure, so testing for negative result never works. > > Signed-off-by: Dmitry Torokhov > --- > > Not tested, found by casual code inspection. > > drivers/irqchip

Re: [PATCH] irqchip: bcm7120-l2: fix error handling of irq_of_parse_and_map

2014-11-15 Thread Florian Fainelli
2014-11-14 14:16 GMT-08:00 Dmitry Torokhov : > Return value of irq_of_parse_and_map() is unsigned int, with 0 > indicating failure, so testing for negative result never works. > > Signed-off-by: Dmitry Torokhov Acked-by: Florian Fainelli > --- > > Not tested, found by casual code inspection. >

[PATCH] irqchip: bcm7120-l2: fix error handling of irq_of_parse_and_map

2014-11-14 Thread Dmitry Torokhov
Return value of irq_of_parse_and_map() is unsigned int, with 0 indicating failure, so testing for negative result never works. Signed-off-by: Dmitry Torokhov --- Not tested, found by casual code inspection. drivers/irqchip/irq-bcm7120-l2.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions