[PATCH] irq_work: Improve the flag definitions

2018-01-04 Thread Frederic Weisbecker
From: Bartosz Golaszewski IRQ_WORK_FLAGS is defined simply to 3UL. This is confusing as it says nothing about its purpose. Define IRQ_WORK_FLAGS as a bitwise OR of IRQ_WORK_PENDING and IRQ_WORK_BUSY and change its name to IRQ_WORK_CLAIMED. While we're at it: use the BIT() macro for all flags. S

Re: [RESEND PATCH] irq_work: improve the flag definitions

2017-12-11 Thread Frederic Weisbecker
2017-12-11 11:59 UTC+01:00, Bartosz Golaszewski : > 2017-11-27 11:52 GMT+01:00 Bartosz Golaszewski : > It's been a couple months since I first posted this patch. Can it be > applied for 4.16? > > @Frederic: I noticed you picked up some irq_work patches in the past > so I'm Cc'ing you. Sure, I'll t

Re: [RESEND PATCH] irq_work: improve the flag definitions

2017-12-11 Thread Frederic Weisbecker
2017-11-27 11:52 UTC+01:00, Bartosz Golaszewski : > IRQ_WORK_FLAGS is defined simply to 3UL. This is confusing as it > says nothing about its purpose. Define IRQ_WORK_FLAGS as a bitwise > OR of IRQ_WORK_PENDING and IRQ_WORK_BUSY and change its name to > IRQ_WORK_CLAIMED. > > While we're at it: use

Re: [RESEND PATCH] irq_work: improve the flag definitions

2017-12-11 Thread Bartosz Golaszewski
2017-11-27 11:52 GMT+01:00 Bartosz Golaszewski : > IRQ_WORK_FLAGS is defined simply to 3UL. This is confusing as it > says nothing about its purpose. Define IRQ_WORK_FLAGS as a bitwise > OR of IRQ_WORK_PENDING and IRQ_WORK_BUSY and change its name to > IRQ_WORK_CLAIMED. > > While we're at it: use t

Re: [RESEND PATCH] irq_work: improve the flag definitions

2017-11-27 Thread Andy Shevchenko
On Mon, Nov 27, 2017 at 12:52 PM, Bartosz Golaszewski wrote: > IRQ_WORK_FLAGS is defined simply to 3UL. This is confusing as it > says nothing about its purpose. Define IRQ_WORK_FLAGS as a bitwise > OR of IRQ_WORK_PENDING and IRQ_WORK_BUSY and change its name to > IRQ_WORK_CLAIMED. > > While we're

[RESEND PATCH] irq_work: improve the flag definitions

2017-11-27 Thread Bartosz Golaszewski
IRQ_WORK_FLAGS is defined simply to 3UL. This is confusing as it says nothing about its purpose. Define IRQ_WORK_FLAGS as a bitwise OR of IRQ_WORK_PENDING and IRQ_WORK_BUSY and change its name to IRQ_WORK_CLAIMED. While we're at it: use the BIT() macro for all flags. Signed-off-by: Bartosz Golasz

Re: [PATCH] irq_work: improve the flag definitions

2017-08-15 Thread Bartosz Golaszewski
2017-08-14 13:56 GMT+02:00 Bartosz Golaszewski : > IRQ_WORK_FLAGS is defined simply to 3UL. This is confusing as it > says nothing about its purpose. Define IRQ_WORK_FLAGS as a bitwise > OR of IRQ_WORK_PENDING and IRQ_WORK_BUSY. > > While we're at it: use the BIT() macro for all flags. > > Signed-o

Re: [PATCH] irq_work: improve the flag definitions

2017-08-14 Thread Bartosz Golaszewski
2017-08-14 14:19 GMT+02:00 Andy Shevchenko : > On Mon, Aug 14, 2017 at 2:56 PM, Bartosz Golaszewski wrote: >> IRQ_WORK_FLAGS is defined simply to 3UL. This is confusing as it >> says nothing about its purpose. Define IRQ_WORK_FLAGS as a bitwise >> OR of IRQ_WORK_PENDING and IRQ_WORK_BUSY. >> >> Wh

Re: [PATCH] irq_work: improve the flag definitions

2017-08-14 Thread Andy Shevchenko
On Mon, Aug 14, 2017 at 2:56 PM, Bartosz Golaszewski wrote: > IRQ_WORK_FLAGS is defined simply to 3UL. This is confusing as it > says nothing about its purpose. Define IRQ_WORK_FLAGS as a bitwise > OR of IRQ_WORK_PENDING and IRQ_WORK_BUSY. > > While we're at it: use the BIT() macro for all flags.

[PATCH] irq_work: improve the flag definitions

2017-08-14 Thread Bartosz Golaszewski
IRQ_WORK_FLAGS is defined simply to 3UL. This is confusing as it says nothing about its purpose. Define IRQ_WORK_FLAGS as a bitwise OR of IRQ_WORK_PENDING and IRQ_WORK_BUSY. While we're at it: use the BIT() macro for all flags. Signed-off-by: Bartosz Golaszewski --- include/linux/irq_work.h | 8