Re: [PATCH] ipv4: avoid divide 0 error in tcp_incr_quickack

2014-11-03 Thread Eric Dumazet
On Mon, 2014-11-03 at 13:31 +0800, chenweilong wrote: > Hi Eric, > > I check the code and find that: > > 1.In function "tcp_rcv_state_process", > the "tcp_initialize_rcv_mss" is called at "step 5: check the ACK field" when > the sk->sk_state is TCP_SYN_RECV > and there is a "tcp_validate_incomi

Re: [PATCH] ipv4: avoid divide 0 error in tcp_incr_quickack

2014-11-02 Thread chenweilong
On 2014/11/3 11:42, Eric Dumazet wrote: > On Mon, 2014-11-03 at 09:29 +0800, Chen Weilong wrote: >> From: Weilong Chen >> >> We got a problem like this: > >> There was a wrong ack packet coming during TCP handshake. The socket's state >> was TCP_SYN_RECV, its rcv_mss was not initialize yet. So >>

Re: [PATCH] ipv4: avoid divide 0 error in tcp_incr_quickack

2014-11-02 Thread Eric Dumazet
On Mon, 2014-11-03 at 09:29 +0800, Chen Weilong wrote: > From: Weilong Chen > > We got a problem like this: > There was a wrong ack packet coming during TCP handshake. The socket's state > was TCP_SYN_RECV, its rcv_mss was not initialize yet. So > tcp_send_dupack -> tcp_enter_quickack_mode got a

[PATCH] ipv4: avoid divide 0 error in tcp_incr_quickack

2014-11-02 Thread Chen Weilong
From: Weilong Chen We got a problem like this: [8801c1a05570] machine_kexec at 81025039 [8801c1a055d0] crash_kexec at 8109b253 [8801c1a056a0] oops_end at 81442aed [8801c1a056d0] die at 81005603 [8801c1a05700] do_trap at 81442448 [f

Re: [PATCH] ipv4: avoid divide 0 error in tcp_incr_quickack

2014-11-02 Thread chenweilong
Sure, Thanks On 2014/11/2 5:06, David Miller wrote: > From: Chen Weilong > Date: Fri, 31 Oct 2014 22:50:47 +0800 > >> From: Weilong Chen >> >> We got a problem like this: >> [8801c1a05570] machine_kexec at 81025039 >> [8801c1a055d0] crash_kexec at 8109b253 >> [880

Re: [PATCH] ipv4: avoid divide 0 error in tcp_incr_quickack

2014-11-01 Thread David Miller
From: Chen Weilong Date: Fri, 31 Oct 2014 22:50:47 +0800 > From: Weilong Chen > > We got a problem like this: > [8801c1a05570] machine_kexec at 81025039 > [8801c1a055d0] crash_kexec at 8109b253 > [8801c1a056a0] oops_end at 81442aed > [8801c1a056d0] di

Re: [PATCH] ipv4: avoid divide 0 error in tcp_incr_quickack

2014-10-31 Thread Eric Dumazet
On Fri, 2014-10-31 at 09:24 -0700, Alexei Starovoitov wrote: > cc-ing netdev > > On Fri, Oct 31, 2014 at 7:50 AM, Chen Weilong wrote: > > From: Weilong Chen > > > > We got a problem like this: > > [8801c1a05570] machine_kexec at 81025039 > > [8801c1a055d0] crash_kexec at ff

Re: [PATCH] ipv4: avoid divide 0 error in tcp_incr_quickack

2014-10-31 Thread Alexei Starovoitov
cc-ing netdev On Fri, Oct 31, 2014 at 7:50 AM, Chen Weilong wrote: > From: Weilong Chen > > We got a problem like this: > [8801c1a05570] machine_kexec at 81025039 > [8801c1a055d0] crash_kexec at 8109b253 > [8801c1a056a0] oops_end at 81442aed > [8801c1a

[PATCH] ipv4: avoid divide 0 error in tcp_incr_quickack

2014-10-31 Thread Chen Weilong
From: Weilong Chen We got a problem like this: [8801c1a05570] machine_kexec at 81025039 [8801c1a055d0] crash_kexec at 8109b253 [8801c1a056a0] oops_end at 81442aed [8801c1a056d0] die at 81005603 [8801c1a05700] do_trap at 81442448 [f