Re: [PATCH] ipmi/watchdog: add missing newlines when printing parameters by sysfs

2020-07-20 Thread Xiongfeng Wang
On 2020/7/21 10:00, Joe Perches wrote: > On Tue, 2020-07-21 at 09:20 +0800, Xiongfeng Wang wrote: >> On 2020/7/21 3:52, Corey Minyard wrote: >>> On Mon, Jul 20, 2020 at 10:03:25AM +0800, Xiongfeng Wang wrote: When I cat some ipmi_watchdog parameters by sysfs, it displays as follows. It

Re: [PATCH] ipmi/watchdog: add missing newlines when printing parameters by sysfs

2020-07-20 Thread Joe Perches
On Tue, 2020-07-21 at 09:20 +0800, Xiongfeng Wang wrote: > On 2020/7/21 3:52, Corey Minyard wrote: > > On Mon, Jul 20, 2020 at 10:03:25AM +0800, Xiongfeng Wang wrote: > > > When I cat some ipmi_watchdog parameters by sysfs, it displays as > > > follows. It's better to add a newline for easy reading

Re: [PATCH] ipmi/watchdog: add missing newlines when printing parameters by sysfs

2020-07-20 Thread Xiongfeng Wang
Hi Corey, Thanks for your reply ! On 2020/7/21 3:52, Corey Minyard wrote: > On Mon, Jul 20, 2020 at 10:03:25AM +0800, Xiongfeng Wang wrote: >> When I cat some ipmi_watchdog parameters by sysfs, it displays as >> follows. It's better to add a newline for easy reading. >> >> root@(none):/# cat /sys

Re: [PATCH] ipmi/watchdog: add missing newlines when printing parameters by sysfs

2020-07-20 Thread Corey Minyard
On Mon, Jul 20, 2020 at 10:03:25AM +0800, Xiongfeng Wang wrote: > When I cat some ipmi_watchdog parameters by sysfs, it displays as > follows. It's better to add a newline for easy reading. > > root@(none):/# cat /sys/module/ipmi_watchdog/parameters/action > resetroot@(none):/# cat /sys/module/ipm

[PATCH] ipmi/watchdog: add missing newlines when printing parameters by sysfs

2020-07-19 Thread Xiongfeng Wang
When I cat some ipmi_watchdog parameters by sysfs, it displays as follows. It's better to add a newline for easy reading. root@(none):/# cat /sys/module/ipmi_watchdog/parameters/action resetroot@(none):/# cat /sys/module/ipmi_watchdog/parameters/preaction pre_noneroot@(none):/# cat /sys/module/ipm