Re: [PATCH] ipc: use list_for_each_entry for list traversing

2013-04-09 Thread Andrew Morton
On Tue, 09 Apr 2013 11:39:07 +0200 Nikola Pajkovsky wrote: > Andrew Morton writes: > > > urgh, that code is sick. What's it doing poking around in the > > list_head internals? > > No idea, it there from beginning of first kernel importation into > git. Where is history before git? The old bi

Re: [PATCH] ipc: use list_for_each_entry for list traversing

2013-04-09 Thread Nikola Pajkovsky
Andrew Morton writes: > On Fri, 5 Apr 2013 15:42:11 +0200 Nikola Pajkovsky > wrote: > >> the ipc/msg.c code does all list operations by hand and it open-codes >> the accesses, instead of using for_each_entry. >> >> ... >> >> --- a/ipc/msg.c >> +++ b/ipc/msg.c >> @@ -237,14 +237,9 @@ static in

Re: [PATCH] ipc: use list_for_each_entry for list traversing

2013-04-08 Thread Andrew Morton
On Fri, 5 Apr 2013 15:42:11 +0200 Nikola Pajkovsky wrote: > the ipc/msg.c code does all list operations by hand and it open-codes > the accesses, instead of using for_each_entry. > > ... > > --- a/ipc/msg.c > +++ b/ipc/msg.c > @@ -237,14 +237,9 @@ static inline void ss_del(struct msg_sender *ms

[PATCH] ipc: use list_for_each_entry for list traversing

2013-04-05 Thread Nikola Pajkovsky
the ipc/msg.c code does all list operations by hand and it open-codes the accesses, instead of using for_each_entry. Signed-off-by: Nikola Pajkovsky --- ipc/msg.c | 35 --- 1 files changed, 8 insertions(+), 27 deletions(-) diff --git a/ipc/msg.c b/ipc/msg.c ind