Re: [PATCH] iov_iter: optimise bvec iov_iter_advance()

2020-12-09 Thread Pavel Begunkov
On 09/12/2020 08:33, Christoph Hellwig wrote: > On Thu, Dec 03, 2020 at 11:48:56AM +, Pavel Begunkov wrote: >> It's inlined and the on-stack iter is completely optimised out. Frankly, >> I'd rather not open-code bvec_iter_advance(), at least for this chunk to >> be findable from bvec.h, e.g. gr

Re: [PATCH] iov_iter: optimise bvec iov_iter_advance()

2020-12-09 Thread Christoph Hellwig
On Thu, Dec 03, 2020 at 11:48:56AM +, Pavel Begunkov wrote: > It's inlined and the on-stack iter is completely optimised out. Frankly, > I'd rather not open-code bvec_iter_advance(), at least for this chunk to > be findable from bvec.h, e.g. grep bvec_iter and bvec_for_each. Though, > I don't l

Re: [PATCH] iov_iter: optimise bvec iov_iter_advance()

2020-12-03 Thread Pavel Begunkov
On 03/12/2020 09:14, Christoph Hellwig wrote: >> @@ -1077,6 +1077,20 @@ void iov_iter_advance(struct iov_iter *i, size_t size) >> i->count -= size; >> return; >> } >> +if (iov_iter_is_bvec(i)) { >> +struct bvec_iter bi; >> + >> +bi.bi_size

Re: [PATCH] iov_iter: optimise bvec iov_iter_advance()

2020-12-03 Thread Christoph Hellwig
> @@ -1077,6 +1077,20 @@ void iov_iter_advance(struct iov_iter *i, size_t size) > i->count -= size; > return; > } > + if (iov_iter_is_bvec(i)) { > + struct bvec_iter bi; > + > + bi.bi_size = i->count; > + bi.bi_bvec_done = i-

[PATCH] iov_iter: optimise bvec iov_iter_advance()

2020-12-02 Thread Pavel Begunkov
iov_iter_advance() is heavily used, but implemented through generic iteration. As bvecs have a specifically crafted advance() function, i.e. bvec_iter_advance(), which is faster and slimmer, use it instead. Signed-off-by: Pavel Begunkov --- lib/iov_iter.c | 14 ++ 1 file changed, 14