Re: [PATCH] iommu/amd: Fix potential @entry null deref

2020-09-18 Thread Joerg Roedel
On Thu, Sep 10, 2020 at 06:16:21PM +0100, Joao Martins wrote: > After commit 26e495f34107 ("iommu/amd: Restore IRTE.RemapEn bit after > programming IRTE"), smatch warns: > > drivers/iommu/amd/iommu.c:3870 amd_iommu_deactivate_guest_mode() > warn: variable dereferenced before check 'e

Re: [PATCH] iommu/amd: Fix potential @entry null deref

2020-09-10 Thread Suravee Suthikulpanit
Thanks for catching this. On 9/11/20 12:16 AM, Joao Martins wrote: After commit 26e495f34107 ("iommu/amd: Restore IRTE.RemapEn bit after programming IRTE"), smatch warns: drivers/iommu/amd/iommu.c:3870 amd_iommu_deactivate_guest_mode() warn: variable dereferenced before check '

[PATCH] iommu/amd: Fix potential @entry null deref

2020-09-10 Thread Joao Martins
After commit 26e495f34107 ("iommu/amd: Restore IRTE.RemapEn bit after programming IRTE"), smatch warns: drivers/iommu/amd/iommu.c:3870 amd_iommu_deactivate_guest_mode() warn: variable dereferenced before check 'entry' (see line 3867) Fix this by moving the @valid assignment to aft