Re: [PATCH] ioctl_tty.2: add TIOCGPTPEER documentation

2017-11-20 Thread Eric W. Biederman
"Michael Kerrisk (man-pages)" writes: > On 08/16/2017 07:14 PM, Eric W. Biederman wrote: >> Aleksa Sarai writes: >> A couple of things to note on the bigger picture. The glibc library on all distributions has been changed to not have a setuid binary pt_chown, that uses ptsna

Re: [PATCH] ioctl_tty.2: add TIOCGPTPEER documentation

2017-11-20 Thread Christian Brauner
On Mon, Nov 20, 2017 at 11:20:13AM +0100, Michael Kerrisk (man-pages) wrote: > On 08/16/2017 07:14 PM, Eric W. Biederman wrote: > > Aleksa Sarai writes: > > > >>> A couple of things to note on the bigger picture. > >>> > >>> The glibc library on all distributions has been changed to not have a >

Re: [PATCH] ioctl_tty.2: add TIOCGPTPEER documentation

2017-11-20 Thread Michael Kerrisk (man-pages)
On 08/16/2017 07:14 PM, Eric W. Biederman wrote: > Aleksa Sarai writes: > >>> A couple of things to note on the bigger picture. >>> >>> The glibc library on all distributions has been changed to not have a >>> setuid binary pt_chown, that uses ptsname. This was the primary fix >>> for the securi

Re: [PATCH] ioctl_tty.2: add TIOCGPTPEER documentation

2017-08-16 Thread Eric W. Biederman
Aleksa Sarai writes: >> A couple of things to note on the bigger picture. >> >> The glibc library on all distributions has been changed to not have a >> setuid binary pt_chown, that uses ptsname. This was the primary fix >> for the security issue. >> >> The behavior of opening /dev/ptmx has been

Re: [PATCH] ioctl_tty.2: add TIOCGPTPEER documentation

2017-08-16 Thread Aleksa Sarai
A couple of things to note on the bigger picture. The glibc library on all distributions has been changed to not have a setuid binary pt_chown, that uses ptsname. This was the primary fix for the security issue. The behavior of opening /dev/ptmx has been changed to perform a path lookup relativ

Re: [PATCH] ioctl_tty.2: add TIOCGPTPEER documentation

2017-08-16 Thread Eric W. Biederman
"Michael Kerrisk (man-pages)" writes: > On 06/09/2017 07:01 PM, Aleksa Sarai wrote: >> The feature this patch references has currently only been accepted into >> tty-testing, but Greg told me to kick this down to man-pages. As a >> result, I can't reference upstream commit id's because the code i

Re: [PATCH] ioctl_tty.2: add TIOCGPTPEER documentation

2017-08-15 Thread Aleksa Sarai
I've applied this patch, and then tweaked the wording a little. Could you please check the following text: TIOCGPTPEERint flags (since Linux 4.13) Given a file descriptor in fd that refers to a pseudoterminal master, open (with the given

Re: [PATCH] ioctl_tty.2: add TIOCGPTPEER documentation

2017-08-15 Thread Michael Kerrisk (man-pages)
On 06/09/2017 07:01 PM, Aleksa Sarai wrote: > The feature this patch references has currently only been accepted into > tty-testing, but Greg told me to kick this down to man-pages. As a > result, I can't reference upstream commit id's because the code isn't in > Linus' tree yet -- should I resend

Re: [PATCH] ioctl_tty.2: add TIOCGPTPEER documentation

2017-06-09 Thread Greg Kroah-Hartman
On Sat, Jun 10, 2017 at 03:01:47AM +1000, Aleksa Sarai wrote: > The feature this patch references has currently only been accepted into > tty-testing, but Greg told me to kick this down to man-pages. As a > result, I can't reference upstream commit id's because the code isn't in > Linus' tree yet -

[PATCH] ioctl_tty.2: add TIOCGPTPEER documentation

2017-06-09 Thread Aleksa Sarai
The feature this patch references has currently only been accepted into tty-testing, but Greg told me to kick this down to man-pages. As a result, I can't reference upstream commit id's because the code isn't in Linus' tree yet -- should I resend this once it lands in tty-next or Linus' tree? Also