Re: [PATCH] ioat: fail self-test if wait_for_completion times out

2015-01-07 Thread Jiang, Dave
On Wed, 2015-01-07 at 13:09 +, Nicholas Mc Guire wrote: > On Wed, 07 Jan 2015, Prarit Bhargava wrote: > > > > > > > On 01/06/2015 10:38 AM, Jiang, Dave wrote: > > - if (dma->device_tx_status(dma_chan, cookie, NULL) != > > DMA_COMPLETE) { > > + if (tmo == 0 || dma->d

Re: [PATCH] ioat: fail self-test if wait_for_completion times out

2015-01-07 Thread Nicholas Mc Guire
On Wed, 07 Jan 2015, Prarit Bhargava wrote: > > > On 01/06/2015 10:38 AM, Jiang, Dave wrote: > -if (dma->device_tx_status(dma_chan, cookie, NULL) != > DMA_COMPLETE) { > +if (tmo == 0 || dma->device_tx_status(dma_chan, cookie, NULL) > +

Re: [PATCH] ioat: fail self-test if wait_for_completion times out

2015-01-07 Thread Prarit Bhargava
On 01/06/2015 10:38 AM, Jiang, Dave wrote: - if (dma->device_tx_status(dma_chan, cookie, NULL) != DMA_COMPLETE) { + if (tmo == 0 || dma->device_tx_status(dma_chan, cookie, NULL) + != DMA_COMPLETE) { >>> >>> Can you please do: >>> + if (tmo == 0 || >>> +

Re: [PATCH] ioat: fail self-test if wait_for_completion times out

2015-01-06 Thread Jiang, Dave
On Tue, 2015-01-06 at 00:42 +, Nicholas Mc Guire wrote: > On Mon, 05 Jan 2015, Jiang, Dave wrote: > > > > > > > > > On Sun, 2014-12-28 at 10:37 +, Nicholas Mc Guire wrote: > > > wait_for_completion_timeout reaching timeout was being ignored, > > > fail the self-test if timeout condit

Re: [PATCH] ioat: fail self-test if wait_for_completion times out

2015-01-05 Thread Nicholas Mc Guire
On Mon, 05 Jan 2015, Jiang, Dave wrote: > > > > On Sun, 2014-12-28 at 10:37 +, Nicholas Mc Guire wrote: > > wait_for_completion_timeout reaching timeout was being ignored, > > fail the self-test if timeout condition occurs. > > > > Not sure about the indentations used (CodingStyle:Chapter

Re: [PATCH] ioat: fail self-test if wait_for_completion times out

2015-01-05 Thread Jiang, Dave
On Sun, 2014-12-28 at 10:37 +, Nicholas Mc Guire wrote: > wait_for_completion_timeout reaching timeout was being ignored, > fail the self-test if timeout condition occurs. > > Not sure about the indentations used (CodingStyle:Chapter 2) > > this was only compile tested with > x86_64_defcon

Re: [PATCH] ioat: fail self-test if wait_for_completion times out

2015-01-02 Thread Prarit Bhargava
On 12/28/2014 05:37 AM, Nicholas Mc Guire wrote: > wait_for_completion_timeout reaching timeout was being ignored, > fail the self-test if timeout condition occurs. > > Not sure about the indentations used (CodingStyle:Chapter 2) > > this was only compile tested with > x86_64_defconfig + CONFIG

[PATCH] ioat: fail self-test if wait_for_completion times out

2014-12-28 Thread Nicholas Mc Guire
wait_for_completion_timeout reaching timeout was being ignored, fail the self-test if timeout condition occurs. Not sure about the indentations used (CodingStyle:Chapter 2) this was only compile tested with x86_64_defconfig + CONFIG_DMA_ENGINE=y + CONFIG_INTEL_IOATDMA=y patch is against linux-ne