Re: [PATCH] intel_idle: Fix uninitialized variable bug

2020-06-25 Thread Rafael J. Wysocki
On Thu, Jun 25, 2020 at 11:05 AM Dan Carpenter wrote: > > On Wed, Jun 24, 2020 at 03:41:05PM +0200, Rafael J. Wysocki wrote: > > On Wed, Jun 24, 2020 at 3:19 PM Dan Carpenter > > wrote: > > > > > > The "tick" variable isn't initialized if "lapic_timer_always_reliable" > > > is true. > > > > If l

Re: [PATCH] intel_idle: Fix uninitialized variable bug

2020-06-25 Thread Dan Carpenter
On Wed, Jun 24, 2020 at 03:41:05PM +0200, Rafael J. Wysocki wrote: > On Wed, Jun 24, 2020 at 3:19 PM Dan Carpenter > wrote: > > > > The "tick" variable isn't initialized if "lapic_timer_always_reliable" > > is true. > > If lapic_timer_always_reliable is true, then > static_cpu_has(X86_FEATURE_AR

Re: [PATCH] intel_idle: Fix uninitialized variable bug

2020-06-24 Thread Rafael J. Wysocki
On Wed, Jun 24, 2020 at 3:19 PM Dan Carpenter wrote: > > The "tick" variable isn't initialized if "lapic_timer_always_reliable" > is true. If lapic_timer_always_reliable is true, then static_cpu_has(X86_FEATURE_ARAT) must also be true AFAICS. So the lapic_timer_always_reliable check in there loo

[PATCH] intel_idle: Fix uninitialized variable bug

2020-06-24 Thread Dan Carpenter
The "tick" variable isn't initialized if "lapic_timer_always_reliable" is true. Fixes: 40ab82e08d78 ("intel_idle: Simplify LAPIC timer reliability checks") Signed-off-by: Dan Carpenter --- drivers/idle/intel_idle.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/idle/