Re: [PATCH] intel_idle: Check cpu_idle_get_driver() for NULL before dereferencing it.

2012-08-16 Thread Rafael J. Wysocki
"); > > > > > printk(KERN_DEBUG PREFIX "intel_idle yielding to %s", > > > - cpuidle_get_driver()->name); > > > + cpuidle_get_driver() ? cpuidle_get_driver()->name : > > > "none"); > > >

Re: [PATCH] intel_idle: Check cpu_idle_get_driver() for NULL before dereferencing it.

2012-08-06 Thread Konrad Rzeszutek Wilk
On Sat, Aug 04, 2012 at 11:56:35PM +0200, Rafael J. Wysocki wrote: > On Thursday, August 02, 2012, Konrad Rzeszutek Wilk wrote: > > If the machine is booted without any cpu_idle driver set > > (b/c disable_cpuidle() has been called) we should follow > > other users of cpu_idle API and check the ret

Re: [PATCH] intel_idle: Check cpu_idle_get_driver() for NULL before dereferencing it.

2012-08-06 Thread Konrad Rzeszutek Wilk
ver() ? cpuidle_get_driver()->name : > > "none"); > > return retval; > > } > > > > > > Rafael Here it is: >From a8b7aa06cacb5f42a90a0d4a0a1a95e230d43fc6 Mon Sep 17 00:00:00 2001 From: Konrad Rzeszutek Wilk Date: Thu, 2 Aug 2

Re: [PATCH] intel_idle: Check cpu_idle_get_driver() for NULL before dereferencing it.

2012-08-04 Thread Rafael J. Wysocki
On Thursday, August 02, 2012, Konrad Rzeszutek Wilk wrote: > If the machine is booted without any cpu_idle driver set > (b/c disable_cpuidle() has been called) we should follow > other users of cpu_idle API and check the return value > for NULL before using it. > > Reported-by: Mark van Dijk > Te

[PATCH] intel_idle: Check cpu_idle_get_driver() for NULL before dereferencing it.

2012-08-02 Thread Konrad Rzeszutek Wilk
If the machine is booted without any cpu_idle driver set (b/c disable_cpuidle() has been called) we should follow other users of cpu_idle API and check the return value for NULL before using it. Reported-by: Mark van Dijk Tested-by: Mark van Dijk Suggested-by: Jan Beulich Signed-off-by: Konrad