Re: [PATCH] intel-iommu fixes

2007-11-15 Thread Denys Vlasenko
On Sunday 28 October 2007 21:51, Al Viro wrote: > -#define MAX_FAULT_REASON_IDX ARRAY_SIZE(fault_reason_strings) > +#define MAX_FAULT_REASON_IDX ARRAY_SIZE(fault_reason_strings) - 1 The macro is unsafe without yet another ()s around it. -- vda - To unsubscribe from this list: send

Re: [PATCH] intel-iommu fixes

2007-10-29 Thread Mark Gross
On Mon, Oct 29, 2007 at 04:51:16AM +, Al Viro wrote: > * off by one in dmar_get_fault_reason() (maximal index in > array is ARRAY_SIZE()-1, not ARRAY_SIZE()) > * NULL noise removal > * __iomem annotation fix > > Signed-off-by: Al Viro <[EMAIL PROTECTED]> > --- > diff --git a/

Re: [PATCH] intel-iommu fixes

2007-10-29 Thread Mark Rustad
On Oct 28, 2007, at 11:51 PM, Al Viro wrote: * off by one in dmar_get_fault_reason() (maximal index in array is ARRAY_SIZE()-1, not ARRAY_SIZE()) * NULL noise removal * __iomem annotation fix Signed-off-by: Al Viro <[EMAIL PROTECTED]> --- diff --git a/drivers/pci/intel-i

[PATCH] intel-iommu fixes

2007-10-28 Thread Al Viro
* off by one in dmar_get_fault_reason() (maximal index in array is ARRAY_SIZE()-1, not ARRAY_SIZE()) * NULL noise removal * __iomem annotation fix Signed-off-by: Al Viro <[EMAIL PROTECTED]> --- diff --git a/drivers/pci/intel-iommu.c b/drivers/pci/intel-iommu.c index 0c4ab3b