Re: [PATCH] initity: try to improve __nocapture annotations

2017-02-02 Thread Arnd Bergmann
On Thu, Feb 2, 2017 at 1:39 AM, Kees Cook wrote: > On Wed, Feb 1, 2017 at 8:11 AM, Arnd Bergmann wrote: >> -void ACPI_INTERNAL_VAR_XFACE >> +void __unverified_nocapture(3) ACPI_INTERNAL_VAR_XFACE >> acpi_debug_print(u32 requested_debug_level, >> u32 line_number, >>

Re: [PATCH] initity: try to improve __nocapture annotations

2017-02-01 Thread Kees Cook
On Wed, Feb 1, 2017 at 8:11 AM, Arnd Bergmann wrote: > There are some additional declarations that got missed in the original patch, > and some annotated functions that use the pointer is a correct but nonobvious > way: > > mm/kasan/kasan.c: In function 'memmove': > mm/kasan/kasan.c:346:7: error:

Re: [PATCH] initity: try to improve __nocapture annotations

2017-02-01 Thread Kees Cook
On Wed, Feb 1, 2017 at 3:38 PM, Rafael J. Wysocki wrote: > On Wed, Feb 1, 2017 at 11:44 PM, Kees Cook wrote: >> On Wed, Feb 1, 2017 at 1:05 PM, Rafael J. Wysocki wrote: >>> On Wed, Feb 1, 2017 at 5:11 PM, Arnd Bergmann wrote: diff --git a/drivers/acpi/acpica/utdebug.c b/drivers/acpi/acpica

Re: [PATCH] initity: try to improve __nocapture annotations

2017-02-01 Thread Rafael J. Wysocki
On Wed, Feb 1, 2017 at 11:44 PM, Kees Cook wrote: > On Wed, Feb 1, 2017 at 1:05 PM, Rafael J. Wysocki wrote: >> On Wed, Feb 1, 2017 at 5:11 PM, Arnd Bergmann wrote: >>> There are some additional declarations that got missed in the original >>> patch, >>> and some annotated functions that use th

Re: [PATCH] initity: try to improve __nocapture annotations

2017-02-01 Thread Kees Cook
On Wed, Feb 1, 2017 at 1:05 PM, Rafael J. Wysocki wrote: > On Wed, Feb 1, 2017 at 5:11 PM, Arnd Bergmann wrote: >> There are some additional declarations that got missed in the original patch, >> and some annotated functions that use the pointer is a correct but nonobvious >> way: >> >> mm/kasan/

Re: [PATCH] initity: try to improve __nocapture annotations

2017-02-01 Thread Rafael J. Wysocki
On Wed, Feb 1, 2017 at 5:11 PM, Arnd Bergmann wrote: > There are some additional declarations that got missed in the original patch, > and some annotated functions that use the pointer is a correct but nonobvious > way: > > mm/kasan/kasan.c: In function 'memmove': > mm/kasan/kasan.c:346:7: error:

[PATCH] initity: try to improve __nocapture annotations

2017-02-01 Thread Arnd Bergmann
There are some additional declarations that got missed in the original patch, and some annotated functions that use the pointer is a correct but nonobvious way: mm/kasan/kasan.c: In function 'memmove': mm/kasan/kasan.c:346:7: error: 'memmove' captures its 2 ('src') parameter, please remove it fro